Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing tests that support legacy exports #116009

Closed
wants to merge 1 commit into from

Conversation

rashmivkulkarni
Copy link
Contributor

Fixes: #111004
The following dashboard functional tests are skipped in #110738 and need to be adapted/removed to reflect the changes:

bwc_import (https://github.com/elastic/kibana/blob/master/test/functional/apps/dashboard/bwc_import.ts)
time_zones (https://github.com/elastic/kibana/blob/master/test/functional/apps/dashboard/time_zones.ts)

…ics to be numbers instead of strings (elastic#115605)

* [Alerting] Changed alerting telemetry throttle and interval metrics to be numbers instead of strings

* fixed test

* fixed typecheck

* set size to 0

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@rashmivkulkarni rashmivkulkarni added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 21, 2021
@rashmivkulkarni rashmivkulkarni requested review from a team as code owners October 21, 2021 19:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 22, 2021

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dashboard legacy format saved objects import functional tests
4 participants