Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Deprecation text for the removal of xpack.reporting.index is wrong #114217

Closed
tsullivan opened this issue Oct 7, 2021 · 7 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label

Comments

@tsullivan
Copy link
Member

tsullivan commented Oct 7, 2021

Kibana version: 7.16

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

Steps to reproduce:

  1. (Using 7.16) Use a custom xpack.reporting.index
  2. View the deprecations in the Upgrade Assistant
  3. Text is wrong for Setting "xpack.reporting.index" is deprecated:
    correctiveActions: {
    manualSteps: [
    i18n.translate('xpack.reporting.deprecations.reportingIndex.manualStepOne', {
    defaultMessage: `If you rely on this setting to achieve multitenancy you should use Spaces, cross-cluster replication, or cross-cluster search instead.`,
    }),
    i18n.translate('xpack.reporting.deprecations.reportingIndex.manualStepTwo', {
    defaultMessage: `To migrate to Spaces, we encourage using saved object management to export your saved objects from a tenant into the default tenant in a space.`,
    }),
    ],
    },

Expected behavior:
Reports are not Space-aware, and using Spaces doesn't resolve issues with multi-tenancy for Reporting.

The text should say something like, "Corrective actions: regenerate reports that need to be available for download in Kibana. You will not have access to reports that are stored in a custom index."

@tsullivan tsullivan added the bug Fixes for quality problems that affect the customer experience label Oct 7, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 7, 2021
@tsullivan
Copy link
Member Author

cc @alexfrancoeur

@tsullivan tsullivan changed the title [Reporting] Corrective action for the removal of xpack.reporting.index is incorrect [Reporting] Deprecation text for the removal of xpack.reporting.index is wrong Oct 7, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Oct 7, 2021
@sscarduzio
Copy link

Are reports expected to be saved into respective spaces in the future? This would be very helpful.

@tsullivan
Copy link
Member Author

Are reports expected to be saved into respective spaces in the future? This would be very helpful.

I'll defer this question to @alexfrancoeur and @sixstringcode

@sixstringcode
Copy link

@sscarduzio That's something we actually haven't discussed that I am aware of. I will look into the idea and make sure we discuss it in our planning conversations. Can you help provide a little more detail on how/why this would be useful for you?

@alexfrancoeur
Copy link

alexfrancoeur commented Oct 11, 2021

Sorry for the late reply here, circling back to the original deprecation warning. We'll likely want @kobelb's thoughts here as well, but I think we should aim for a descriptive and actionable deprecation warning. If needed, we can likely rope in our tech writing team for some thoughts on how best to craft this message.

What we choose to display also feels tightly coupled to this answer: #82020 (comment)

@tsullivan
Copy link
Member Author

Closed via #114219

@sophiec20 sophiec20 added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label
Projects
None yet
Development

No branches or pull requests

6 participants