Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] fix the deprecation text on removal of xpack.reporting.index #114219

Merged
merged 15 commits into from
Oct 13, 2021
Merged

[Reporting] fix the deprecation text on removal of xpack.reporting.index #114219

merged 15 commits into from
Oct 13, 2021

Conversation

tsullivan
Copy link
Member

Summary

Resolves #114217

@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Reporting Services v7.16.0 labels Oct 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Oct 7, 2021
@tsullivan tsullivan requested a review from gchaps October 7, 2021 01:09
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

debadair
debadair reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gail & I reviewed--added some comments & questions.

x-pack/plugins/reporting/server/config/index.ts Outdated Show resolved Hide resolved
x-pack/plugins/reporting/server/config/index.ts Outdated Show resolved Hide resolved
x-pack/plugins/reporting/server/config/index.ts Outdated Show resolved Hide resolved
jloleysens
jloleysens approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting changes LGTM. Left a couple of nits.

x-pack/plugins/reporting/server/config/index.ts Outdated Show resolved Hide resolved
x-pack/plugins/reporting/server/config/index.ts Outdated Show resolved Hide resolved
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan added the backport:skip This commit does not require backporting label Oct 13, 2021
@tsullivan tsullivan merged commit b647bf2 into elastic:7.x Oct 13, 2021
@tsullivan tsullivan deleted the reporting/upgrade-assistant-transition-2 branch October 13, 2021 21:20
This was referenced Oct 14, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadair debadair debadair left review comments

@jloleysens jloleysens jloleysens approved these changes

@gchaps gchaps Awaiting requested review from gchaps

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsullivan @elasticmachine @kibanamachine @debadair @jloleysens