Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/aliases·ts - detection engine api security and spaces enabled Tests involving aliases of source indexes and the signals index should keep the original alias value such as "host_alias" from a source index when the value is indexed #114581

Closed
kibanamachine opened this issue Oct 11, 2021 · 2 comments
Closed

Failing test: X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/aliases·ts - detection engine api security and spaces enabled Tests involving aliases of source indexes and the signals index should keep the original alias value such as "host_alias" from a source index when the value is indexed #114581

kibanamachine opened this issue Oct 11, 2021 · 2 comments
Assignees
@FrankHassanabad
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 11, 2021 •
edited
Loading

A test failed on a tracked branch

Error: expected [ 'host name 2',
  'host name 3',
  'host name 4',
  'host name 1' ] to sort of equal [ 'host name 1',
  'host name 2',
  'host name 3',
  'host name 4' ]
    at Assertion.assert (/opt/local-ssd/buildkite/builds/kb-cigroup-6-22abcec4bb4ef5cc/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/opt/local-ssd/buildkite/builds/kb-cigroup-6-22abcec4bb4ef5cc/elastic/kibana-hourly/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/detection_engine_api_integration/security_and_spaces/tests/aliases.ts:57:23)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/opt/local-ssd/buildkite/builds/kb-cigroup-6-22abcec4bb4ef5cc/elastic/kibana-hourly/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: '[\n  "host name 2"\n  "host name 3"\n  "host name 4"\n  "host name 1"\n]',
  expected: '[\n  "host name 1"\n  "host name 2"\n  "host name 3"\n  "host name 4"\n]',
  showDiff: true
}

First failure: CI Build - 7.x
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 11, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 11, 2021
@mistic mistic added Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team labels Oct 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 12, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - master

@FrankHassanabad FrankHassanabad mentioned this issue Oct 20, 2021
Merged
1 task
@FrankHassanabad FrankHassanabad self-assigned this Oct 20, 2021
FrankHassanabad added a commit that referenced this issue Oct 20, 2021
@FrankHassanabad
[Security Solutions] Fixes 11 different flakey FTR/e2e tests and scen…
a01165a 
…arios (#115688)

## Summary

Fixes flakes across tests that have either been skipped or have been a source of flake in the categories of:
* Sorting fixes because Elasticsearch can return hits/arrays back in different orders
* Flat array fixes because Elasticsearch can sometimes return `[]` or `[[]]` in-deterministically in some cases 🤷 , so we just flatten the array out completely and test for `[]` within those tests.
* `waitForSignalsToBePresent` was missing in a test and sometimes we would get an empty array response which would fail CI.

Also I audited other tests for `[[]]` and `waitForSignalsToBePresent` and fixed them where they were present or if the `waitForSignalsToBePresent` count was incorrect. This should give us more stability when the CI is under pressure.

Sorting fixes:
#115554
#115321
#115319
#114581


Flat array fixes:
#89052
#115315
#115308
#115304
#115313
#113418

Missing additional check for "waitForSignalsToBePresent" or incorrect number of signals to wait for fixes:
#115310


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 20, 2021
@FrankHassanabad @kibanamachine
[Security Solutions] Fixes 11 different flakey FTR/e2e tests and scen…
711c67c 
…arios (elastic#115688)

## Summary

Fixes flakes across tests that have either been skipped or have been a source of flake in the categories of:
* Sorting fixes because Elasticsearch can return hits/arrays back in different orders
* Flat array fixes because Elasticsearch can sometimes return `[]` or `[[]]` in-deterministically in some cases 🤷 , so we just flatten the array out completely and test for `[]` within those tests.
* `waitForSignalsToBePresent` was missing in a test and sometimes we would get an empty array response which would fail CI.

Also I audited other tests for `[[]]` and `waitForSignalsToBePresent` and fixed them where they were present or if the `waitForSignalsToBePresent` count was incorrect. This should give us more stability when the CI is under pressure.

Sorting fixes:
elastic#115554
elastic#115321
elastic#115319
elastic#114581


Flat array fixes:
elastic#89052
elastic#115315
elastic#115308
elastic#115304
elastic#115313
elastic#113418

Missing additional check for "waitForSignalsToBePresent" or incorrect number of signals to wait for fixes:
elastic#115310


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine added a commit that referenced this issue Oct 20, 2021
@kibanamachine @FrankHassanabad
[Security Solutions] Fixes 11 different flakey FTR/e2e tests and scen…
cd613d3 
…arios (#115688) (#115699)

## Summary

Fixes flakes across tests that have either been skipped or have been a source of flake in the categories of:
* Sorting fixes because Elasticsearch can return hits/arrays back in different orders
* Flat array fixes because Elasticsearch can sometimes return `[]` or `[[]]` in-deterministically in some cases 🤷 , so we just flatten the array out completely and test for `[]` within those tests.
* `waitForSignalsToBePresent` was missing in a test and sometimes we would get an empty array response which would fail CI.

Also I audited other tests for `[[]]` and `waitForSignalsToBePresent` and fixed them where they were present or if the `waitForSignalsToBePresent` count was incorrect. This should give us more stability when the CI is under pressure.

Sorting fixes:
#115554
#115321
#115319
#114581


Flat array fixes:
#89052
#115315
#115308
#115304
#115313
#113418

Missing additional check for "waitForSignalsToBePresent" or incorrect number of signals to wait for fixes:
#115310


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankHassanabad FrankHassanabad

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FrankHassanabad @mistic @elasticmachine @kibanamachine