Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Timelion traps focus #11525

Closed
snide opened this issue Apr 28, 2017 · 0 comments
Closed

Accessibility: Timelion traps focus #11525

snide opened this issue Apr 28, 2017 · 0 comments
Assignees
@timroes
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@snide
Copy link
Contributor

snide commented Apr 28, 2017

Problem

Timelion traps the focus of the tab key, which should be used to navigate. We use it to autocomplete selections in the code.

Solution

I think it's OK to turn off the tab completion here and just use the enter key. Alternatively we can key the ESC to remove focus, and use an advanced settings accessibility toggle to decide whether the tab key works.
@snide snide added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Apr 28, 2017
@cjcenizal cjcenizal mentioned this issue Apr 28, 2017
Closed
38 tasks
@cjcenizal cjcenizal added Project:Accessibility Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels May 17, 2017
@cjcenizal cjcenizal mentioned this issue Jun 6, 2017
Closed
20 tasks
@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
@timroes timroes self-assigned this Aug 16, 2017
timroes pushed a commit to timroes/kibana that referenced this issue Aug 16, 2017
Make timelion autocompletion properly accessible
ac23676 
Fixes elastic#11533, fixes elastic#11525, fixes elastic#12908
This was referenced Aug 16, 2017
Merged
Closed
timroes added a commit that referenced this issue Aug 21, 2017
@timroes
Improve timelion accessibility (#13531)
904bda9 
* Fix broken refresh shortcut for non OS X

On non OS X systems, the e.metaKey is most likely the windows key.
Hotkeys with the windows key are usually used as global (non application
internal) hotkeys. Also the documentation states, that Ctrl + Enter
should also work. With this commit it doesn't matter whether you press
the Meta or the Ctrl key + Enter.

* Make timelion datepicker more accessible

* Add meaningful labels to each interval shortcut, and
* Add a proper label to the custom input text field

* Make save options keyboard accessible, fix #12246, fix #12487

* Make sort button of saved-object-finder accessible, fix #12486

* Label timelion options correctly, fix #12907

* Make timelion legends keyboard accessible, fix #11844

* Make timelion autocompletion properly accessible

Fixes #11533, fixes #11525, fixes #12908

* Make timelion charts and actions accessible, fix #12909

* Add some more inline comments

* Fix HTML styles according to styleguide

* Replace sr-only by kuiScreenReaderOnly

* Make timelion autocompletion work with ARIA 1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

Labels
bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snide @timroes @tbragin @cjcenizal