Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Query based event annotations #129299

Closed
mbondyra opened this issue Apr 4, 2022 · 2 comments
Closed

[Lens] Query based event annotations #129299

mbondyra opened this issue Apr 4, 2022 · 2 comments
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Apr 4, 2022

Phase 1

  1. Refactor drag and drop [Lens] Refactor drag and drop  #128506
  2. Reshape code for existing manual annotations:
    a. move fetching inside event_annotation plugin
    b. utilize event_annotation_group expression following the simplified expression call from the design doc:
kibana_context
| fetch_event_annotations group={
  event_annotation_group
    annotations={manual_event_annotation time=”2021-12-12 12:34” color=”red” text=”My manual annotation”}
    annotations={manual_event_annotation time=”2021-12-12 12:56” color=”green” text=”another manual annotation” icon=”checkmark”}
} 
  1. Introduce query-based event annotations
    a. add data view as a dependency for event annotation group
    b. display data view switcher in Lens UI
    c. add Query based annotations (built UI, fetching logic according to the spec doc, adding expression integration)
kibana_context
| fetch_event_annotations group={
  event_annotation_group
    dataView={loadDataView id=”1234”}
    annotations={manual_event_annotation time=”2021-12-12 12:34” color=”red” text=”My manual annotation”}
    annotations={manual_event_annotation time=”2021-12-12 12:56” color=”green” text=”another manual annotation” icon=”checkmark”}
    annotations={query_event_annotation filter={kql “status.code>500”} color=”red” text=”500 error” fields=”agent.raw” fields=”host.raw”}
} 
  1. Add TSVB -> Lens for annotations

Linking #62277

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Apr 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra
Copy link
Contributor Author

Closing this one as it was mostly resolved by #138753 and others. Followup issues are being created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants