-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Refactor field select component as shared #134773
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment for your review. Thanks!
'lnFieldPicker__option--incompatible': !compatible, | ||
'lnFieldPicker__option--nonExistant': !exists, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these classes being applied in the appropriate circumstances? When running locally, I noticed that some items in the field selector weren't being given these classes and accompanying color styling that they would have been given previously.
For example, in the screenshot below, I'd expect @timestamp
and agent.keyword
fields to be given the incompatible treatment (as the "Median" function was selected).
Agree with Michael that it seems like there is some information missing in the field list - non-cpmpatible fields are not shown subdued |
The issue should be solved now: the typecast was covering the fact that fields were grouped, leading to the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected, LGTM
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Summary
This PR refactors the field select component into a shared component that can be used outside of the
indexpattern
datasource area. This is required for #129299 .The component is an extra layer on top of EUI combobox with specific ES field knowledge + some extra truncation logic for longer names.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers