-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure UI] Hosts: Convert existing KPI summary metric charts to LensEmbeddable counterparts #150550
Comments
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
This is blocked by #150600. |
I've added this ticket as part of the performance improvement because based on some tests I've run, Lens way to request the data is better than what we doing now: more details https://github.com/elastic/obs-infraobs-team/issues/909#issuecomment-1429961510 |
@neptunian since we're not going to use |
@neptunian found out that we are using the wrong fields in the RX and TX metric charts: ( #150600), and we tried to build the KPI tiles for RX and TX using the correct The good news is that we managed to build them using lens: The bad new is that the average on the bottom right side is wrong (as you can see in the second screenshot). So we're now partially blocked by this ticket instead of the one mentioned previously. I think we can start migrating the KPIs, but we can't release them with this bug. |
Cheers for being proactive here @crespocarlos . Couple of Qs:
If we find we need this for the Improve Hosts Feature UI Responsiveness with enterprise-level datasets epic to be successful, I can push it with the Lens to try and get it prioritised for 8.8.. If they can't do it, we'll either have to: (a) Migrate to Lens but work around this (e.g. could we change the metrics being shown whilst we wait for the issue to be resolved... Would you mind:
Depending on the answers, we can perhaps discuss with @neptunian on whether we go for (a), (b) or (c). |
The ticket you've mentioned is a bug. I'd consider it to be a blocker too.
In the tests I've run, Lens performed better in general. I wouldn't say that not migrating to Lens will considerably slow down the page. We can continue to use the current custom API, if Lens team doesn't prioritize them for 8.8, making a couple of adjustments on the frontend to try to improve the performance of the KPIs. |
Hey @crespocarlos, thanks for that.
Cool - that'll help with prioritisation in the Lens team for the following ticket: If I remember right, I think you had some empirical data on how much switching the KPI tiles to lens would improve performance? Would you mind adding that to the bug ticket to help @ninoslavmiskovic prioritise accordingly? He has a lot of tickets so adding concise description/data of the expected performance increase will help him prioritise. |
There are still some missing details in Lens' Metric chart. I opened a ticket proposing a few changes @roshan-elastic , I think this is a blocker because the charts built with Lens won't look the same as the current KPI charts. What do you think? |
Hey @crespocarlos - as discussed:
Once the following issue is resolved, we can add in an issue to update these KPI tiles: (feel free to add an issue yourself and just do it if you notice the above is completed) |
They do mention it already: "Number of bytes which have been received per second on the public interfaces of the hosts."
Based on [Infrastructure UI] Hosts: Show icon and tooltip in the Metrics component summary#150318. I would leave the icons out for now. wdyt? |
Hey @crespocarlos,
Let me know once you feel the KPI tiles are ready and I can feed back before you submit a PR. Shout if you need anything though. |
Completed |
Summary
We have plenty of incentives for adopting the platform components such as LensEmbeddables because they offer lots of options for the user to further explore the data that the visualizations represent. This proposes to replace our existing KPI summary metric charts with LensEmbeddables.
The text was updated successfully, but these errors were encountered: