Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Support suffix, subtitle and number of decimal places in the Metric chart #154529

Closed
crespocarlos opened this issue Apr 6, 2023 · 3 comments
Closed

[Lens] Support suffix, subtitle and number of decimal places in the Metric chart #154529

crespocarlos opened this issue Apr 6, 2023 · 3 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@crespocarlos
Copy link
Contributor

crespocarlos commented Apr 6, 2023 •
edited
Loading

Describe the feature

I'd like to propose adding support for Decimal and Suffix options in the new Metric chart, similarly to what can be done with the Legacy Metric.

Legacy Metric Value format options:
image

Besides that, currently, in @elastic/charts <Metric /> component it's possible to pass a subtitle. It'd be nice to have an option in Lens for that too.

Current
image

Proposed
image

We're using the insertOrReplaceFormulaColumn from FormulaAPI, so it would be nice if these configuration options, including the proposed subtitle parameter, are reflected in the column object. Currently, It doesn't accept passing suffix, even if a visualization type supports it.
@crespocarlos crespocarlos added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Apr 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@crespocarlos crespocarlos mentioned this issue Apr 6, 2023
Closed
@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Apr 6, 2023
@drewdaemon
Copy link
Contributor

drewdaemon commented Apr 6, 2023 •
edited
Loading

Subtitle is already supported
Screenshot 2023-04-06 at 7 54 04 AM

The other asks relate to (potentially blocked by) #154306

@stratoula
Copy link
Contributor

As Drew mentions we will tackle the other issue here #154306 so I closing this as duplicate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@drewdaemon @crespocarlos @elasticmachine @stratoula