Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Firefox UI Functional Tests - Console.test/functional/apps/console/_variables·ts - console app Console variables with variables in request body should send a successful request #157776

Closed
kibanamachine opened this issue May 15, 2023 · 28 comments
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented May 15, 2023

A test failed on a tracked branch

Error: retry.try timeout: Error: expected '400' to sort of equal 200
    at Assertion.assert (expect.js:100:11)
    at Assertion.eql (expect.js:244:8)
    at _variables.ts:68:29
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:68:21)
    at RetryService.try (retry.ts:31:12)
    at Context.<anonymous> (_variables.ts:66:9)
    at Object.apply (wrap_function.js:73:16)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.try (retry.ts:31:12)
    at Context.<anonymous> (_variables.ts:66:9)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - 8.8

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label May 15, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label May 15, 2023
@mistic mistic added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label May 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 15, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.8

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.8

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented May 26, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

8.8: 35f824a
main: 2ef9994

@alisonelizabeth
Copy link
Contributor

I did a quick manual test of the variable functionality in Console and everything worked as expected. Removing the blocker tag for now, we will need to investigate the test itself.

@alisonelizabeth
Copy link
Contributor

In #160442, I re-enabled this test to run on Chrome.

@alisonelizabeth
Copy link
Contributor

I'm going to close this issue since the test is running on Chrome. I think this gives us sufficient coverage.

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@delanni
Copy link
Contributor

delanni commented Sep 18, 2024

@sabarasaba - did anything improve in terms of the FF stability? The test seems to be still flaking out recently, and I've seen you recently re-enabled this: https://github.com/elastic/kibana/pull/190698/files#diff-0885594a1539654c1240dcc0a46e1888302985dcd5b4898039ecac7cbf8c2eeeR19

@sabarasaba
Copy link
Member

I was about to skip it again, I've ran it through the flaky test runner 100x few times and was passing just fine before I merged it. I'm really unsure of why its failing again :(

@delanni
Copy link
Contributor

delanni commented Sep 18, 2024

Let's put it back to skipped then

@sabarasaba
Copy link
Member

PR for that: #193288

@delanni
Copy link
Contributor

delanni commented Sep 18, 2024

on the screenshot of the error, it seems that the error is with parsing a JSON that contains a \u0009 before "query" - I checked and \u0009 is a tab character, so probably this line in the code is interpreted differently:

await PageObjects.console.enterText(`{\n\t"query": "\${query1}"`);

Should we try without the \n\t? It's still a valid JSON

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@jbudz
Copy link
Member

jbudz commented Sep 18, 2024

/skip

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

Skipped

main: aa4bce0

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@sabarasaba
Copy link
Member

Adressed with #193508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

7 participants