Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of @kbn/ui-framework from PromptPage #160122

Closed
4 tasks
legrego opened this issue Jun 21, 2023 · 1 comment · Fixed by #165513
Closed
4 tasks

Remove usage of @kbn/ui-framework from PromptPage #160122

legrego opened this issue Jun 21, 2023 · 1 comment · Fixed by #165513
Assignees
@thomheymann
Labels
chore Feature:Security/Session Management Platform Security - Session Management Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@legrego
Copy link
Member

legrego commented Jun 21, 2023

The security plugin provides a PromptPage which powers a few of our SSR'd pages. This page makes use of @kbn/ui-framework, which is deprecated, and needs to be removed from the project (see #46410).

We should perform a manual visual regression test to ensure that removing this framework will not alter the rendered pages.

Usages

  • UnauthenticatedPage: x-pack/plugins/security/server/authentication/unauthenticated_page.tsx
  • ResetSessionPage: x-pack/plugins/security/server/authorization/reset_session_page.tsx

Tasks
Beta Give feedback
@legrego legrego added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Session Management Platform Security - Session Management labels Jun 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego mentioned this issue Jun 21, 2023
Closed
@thomheymann thomheymann self-assigned this Sep 1, 2023
@thomheymann thomheymann mentioned this issue Sep 1, 2023
Merged
thomheymann added a commit that referenced this issue Sep 5, 2023
@thomheymann @kibanamachine
Remove deprecated styles and components from static error pages (#165513
0fa2223 
)

Resolves #160122

## Summary

Remove deprecated styles and components from static error pages

## Screenshot

<img width="696" alt="Screenshot 2023-09-01 at 19 45 13"
src="https://github.com/elastic/kibana/assets/190132/575deadf-9efd-4e63-8752-df5b69de5bd1">

## Testing

- Create a user without any roles and try to login

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomheymann thomheymann

Labels
chore Feature:Security/Session Management Platform Security - Session Management Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated styles and components from static error pages thomheymann/kibana
3 participants
@thomheymann @legrego @elasticmachine