Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM][HTTP Versioning] Version Bulk Edit Endpoint #161395

Closed
JiaweiWu opened this issue Jul 6, 2023 · 1 comment · Fixed by #161912
Closed

[RAM][HTTP Versioning] Version Bulk Edit Endpoint #161395

JiaweiWu opened this issue Jul 6, 2023 · 1 comment · Fixed by #161912
Assignees
@JiaweiWu
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0

Comments

@JiaweiWu
Copy link
Contributor

JiaweiWu commented Jul 6, 2023

Parent issue: #157883

Version the rule bulk edit endpoint
@JiaweiWu JiaweiWu added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.10.0 labels Jul 6, 2023
@JiaweiWu JiaweiWu self-assigned this Jul 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@JiaweiWu JiaweiWu moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Jul 7, 2023
@JiaweiWu JiaweiWu moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management Jul 13, 2023
@JiaweiWu JiaweiWu mentioned this issue Jul 13, 2023
Merged
1 task
JiaweiWu added a commit that referenced this issue Jul 25, 2023
@JiaweiWu @kibanamachine
[RAM][HTTP Versioning] Version Rule Bulk Edit Endpoint (#161912)
d4e6a19 
## Summary

Resolves: #161395
Parent Issue: #157883

Adds versioned types to the rule `bulk_edit` endpoint.

This PR also moves around the folder structure slightly, by adding a sub
folder for the `data`/`route`/`application` methods:

## Before

![image](https://github.com/elastic/kibana/assets/74562234/3ae19871-cc5c-4180-b099-5fed86c3870b)

## After

![image](https://github.com/elastic/kibana/assets/74562234/bbd67bb4-4899-4f65-966e-64964f994a04)

Notice I added a `methods` folder to contain the methods, I did the same
for the `data` and `route` folders as well. I think this improves the
hierarchy of these modules, If folks are ok with it then I will update
the doc with the new folder structure.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@JiaweiWu @kibanamachine
[RAM][HTTP Versioning] Version Rule Bulk Edit Endpoint (elastic#161912)
ea64152 
## Summary

Resolves: elastic#161395
Parent Issue: elastic#157883

Adds versioned types to the rule `bulk_edit` endpoint.

This PR also moves around the folder structure slightly, by adding a sub
folder for the `data`/`route`/`application` methods:

## Before

![image](https://github.com/elastic/kibana/assets/74562234/3ae19871-cc5c-4180-b099-5fed86c3870b)

## After

![image](https://github.com/elastic/kibana/assets/74562234/bbd67bb4-4899-4f65-966e-64964f994a04)

Notice I added a `methods` folder to contain the methods, I did the same
for the `data` and `route` folders as well. I think this improves the
hierarchy of these modules, If folks are ok with it then I will update
the doc with the new folder structure.

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaweiWu JiaweiWu

Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM][HTTP Versioning] Version Rule Bulk Edit Endpoint JiaweiWu/kibana
2 participants
@elasticmachine @JiaweiWu