Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] The "Show top N" action inside the timeline doesn't take timeline filter and query into consideration #165075

Closed
machadoum opened this issue Aug 29, 2023 · 4 comments
Closed

[Security Solution] The "Show top N" action inside the timeline doesn't take timeline filter and query into consideration #165075

machadoum opened this issue Aug 29, 2023 · 4 comments
Assignees
@machadoum
Labels
bug Fixes for quality problems that affect the customer experience fixed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.10.3 v8.11.0

Comments

@machadoum
Copy link
Member

Describe the bug:
The "Show top N" action inside the timeline doesn't take timeline filter and query into consideration

Kibana/Elasticsearch Stack version:
8.9

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Timeline

Steps to reproduce:

  1. Open timeline
  2. Add a filter for a field
  3. Hover the field and select "show top N"

Current behavior:
All values show up in the visualization

Expected behavior:
Only the filtered value shows up in the visualization

Screenshots (if relevant):
Screenshot 2023-08-29 at 10 23 25
Screenshot 2023-08-29 at 10 23 40
@machadoum machadoum added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.9.0 labels Aug 29, 2023
@machadoum machadoum self-assigned this Aug 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added the Team:Threat Hunting Security Solution Threat Hunting Team label Aug 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@machadoum machadoum added v8.9.2 and removed v8.9.0 labels Aug 29, 2023
@semd semd mentioned this issue Aug 29, 2023
Closed
@machadoum machadoum mentioned this issue Aug 29, 2023
Merged
machadoum added a commit that referenced this issue Aug 30, 2023
@machadoum
[Security Solutions] Fix The 'Show top N' action inside the timeline (#…
b2371c9 
…165109)

issue: #165075

## Summary

The "Show top N" action inside the timeline doesn't take the timeline
filter and query into consideration

### Solutions
Pass the `combinedQuery` created by the `top_n` component as a filter to
Lens and disable `applyGlobalQueriesAndFilters` property (only for
`top_n` component).
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 30, 2023
@machadoum
[Security Solutions] Fix The 'Show top N' action inside the timeline (e…
1001488 
…lastic#165109)

issue: elastic#165075

## Summary

The "Show top N" action inside the timeline doesn't take the timeline
filter and query into consideration

### Solutions
Pass the `combinedQuery` created by the `top_n` component as a filter to
Lens and disable `applyGlobalQueriesAndFilters` property (only for
`top_n` component).

(cherry picked from commit b2371c9)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 30, 2023
@machadoum
[Security Solutions] Fix The 'Show top N' action inside the timeline (e…
e37aaf5 
…lastic#165109)

issue: elastic#165075

## Summary

The "Show top N" action inside the timeline doesn't take the timeline
filter and query into consideration

### Solutions
Pass the `combinedQuery` created by the `top_n` component as a filter to
Lens and disable `applyGlobalQueriesAndFilters` property (only for
`top_n` component).

(cherry picked from commit b2371c9)
machadoum referenced this issue Sep 27, 2023
@kibanamachine @machadoum
[8.10.3] [Security Solutions] Fix The 'Show top N' action inside the …
5e0d427 
…timeline (#165109) (#165231)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solutions] Fix The 'Show top N' action inside the timeline
(#165109)](#165109)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"machadoum@gmail.com"},"sourceCommit":{"committedDate":"2023-08-30T12:45:00Z","message":"[Security
Solutions] Fix The 'Show top N' action inside the timeline
(#165109)\n\nissue:
https://github.com/elastic/kibana/issues/165075\r\n\r\n##
Summary\r\n\r\nThe \"Show top N\" action inside the timeline doesn't
take the timeline\r\nfilter and query into consideration\r\n\r\n###
Solutions\r\nPass the `combinedQuery` created by the `top_n` component
as a filter to\r\nLens and disable `applyGlobalQueriesAndFilters`
property (only for\r\n`top_n`
component).","sha":"b2371c9093061760620923e3aa2ef82a68ee700b","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.10.0","v8.11.0","v8.9.2"],"number":165109,"url":"https://github.com/elastic/kibana/pull/165109","mergeCommit":{"message":"[Security
Solutions] Fix The 'Show top N' action inside the timeline
(#165109)\n\nissue:
https://github.com/elastic/kibana/issues/165075\r\n\r\n##
Summary\r\n\r\nThe \"Show top N\" action inside the timeline doesn't
take the timeline\r\nfilter and query into consideration\r\n\r\n###
Solutions\r\nPass the `combinedQuery` created by the `top_n` component
as a filter to\r\nLens and disable `applyGlobalQueriesAndFilters`
property (only for\r\n`top_n`
component).","sha":"b2371c9093061760620923e3aa2ef82a68ee700b"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165109","number":165109,"mergeCommit":{"message":"[Security
Solutions] Fix The 'Show top N' action inside the timeline
(#165109)\n\nissue:
https://github.com/elastic/kibana/issues/165075\r\n\r\n##
Summary\r\n\r\nThe \"Show top N\" action inside the timeline doesn't
take the timeline\r\nfilter and query into consideration\r\n\r\n###
Solutions\r\nPass the `combinedQuery` created by the `top_n` component
as a filter to\r\nLens and disable `applyGlobalQueriesAndFilters`
property (only for\r\n`top_n`
component).","sha":"b2371c9093061760620923e3aa2ef82a68ee700b"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <machadoum@gmail.com>
@ghost
Copy link

ghost commented Oct 6, 2023

Hi @MadameSheema

we have validated this issue on 8.10.3 and found it fixed now. ✔️

Build Details:
Version:8.10.3
commit:5aee3c4fba328838fcf0be6a3ff2248a4c0120dd
build:66480

screen-shot:

image

image

@MadameSheema
Copy link
Member

This issue has been fixed on 8.11.0-BC1 as well. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machadoum machadoum

Labels
bug Fixes for quality problems that affect the customer experience fixed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.10.3 v8.11.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@machadoum @elasticmachine @MadameSheema