Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta][Lens] Color mapping post MVP tasks #167506

Open
12 of 20 tasks
markov00 opened this issue Sep 28, 2023 · 2 comments
Open
12 of 20 tasks

[meta][Lens] Color mapping post MVP tasks #167506

markov00 opened this issue Sep 28, 2023 · 2 comments
Assignees
@gvnmagni
Labels
Feature:Lens Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@markov00
Copy link
Member

markov00 commented Sep 28, 2023 •
edited by teresaalvarezsoler
Loading

As post MVP phase of the color mapping, here is a list of quick fixes, enhancements:

Post MVP (high priority)
Beta Give feedback
  1. [Lens] telemetry for color mapping #175116
    Feature:Lens Team:Visualizations backport:skip release_note:skip v8.13.0
  4. Warning sign on same terms for different color mapping doesn't display any message to the user #167880
    Feature:Lens Team:Visualizations discuss enhancement
  6. [Lens] Internationalise color mapping special tokens #168151
    Feature:Lens Team:Visualizations bug impact:medium
    markov00
  7. [Lens] Add option to color all terms in new color mapping UX #168891
    Team:Visualizations discuss enhancement impact:high
    markov00

Post MVP
Beta Give feedback
  1. [Lens] Color Mapping style Enhancements #167703
    Feature:Lens Team:Visualizations enhancement impact:low loe:medium
  2. [Lens] Color options for string cells in tables #179322
    Feature:Data Table Feature:Lens Team:Visualizations impact:medium loe:medium
    nickofthyme
  3. [Lens][Color mapping] Palette authoring #172139
    Feature:Lens Team:Visualizations enhancement impact:low
  8. [Lens] Allow non-numeric metrics for metric vis #137756
    Feature:Lens Team:Visualizations enhancement impact:medium
    mbondyra

Image 1
@markov00 markov00 added Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@MichaelMarcialis
Copy link
Contributor

Add predefined gradient configurations

@markov00, @gvnmagni: I just wanted to add that we should discuss this point before any formal development effort is made on it. Our ability to provide prefabricated gradient color mappings becomes more difficult without the concept of a higher-level color mapping saved object. What we don't want to do is attempt to burden the color palette saved object to accommodate this, as color palettes exist apart from color scale and assignment mappings. We discussed this early on and ultimately decided that we wanted to separate color scale and gradient configuration from palettes (and have palettes only serve as a list of colors).

@markov00 markov00 mentioned this issue Oct 5, 2023
Merged
markov00 added a commit that referenced this issue Oct 5, 2023
@markov00
[lens] color mapping general ux fixes (#167997)
6f62f7b 
## Summary

Fixes the following issues with the Color mapping MVP (see
[here](#167506)):
- refactored the color contrast check and the RGB text input to avoid
popover flickering
- replaced categorical/sequential icons for color scales
- add dot to complete the tooltip sentence.
- fix #167880 by adding a
tooltip to the warning sign
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 5, 2023
@markov00
[lens] color mapping general ux fixes (elastic#167997)
afde638 
## Summary

Fixes the following issues with the Color mapping MVP (see
[here](elastic#167506)):
- refactored the color contrast check and the RGB text input to avoid
popover flickering
- replaced categorical/sequential icons for color scales
- add dot to complete the tooltip sentence.
- fix elastic#167880 by adding a
tooltip to the warning sign

(cherry picked from commit 6f62f7b)
kibanamachine referenced this issue Oct 5, 2023
@kibanamachine @markov00
[8.11] [lens] color mapping general ux fixes (#167997) (#168161)
1873987 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[lens] color mapping general ux fixes
(#167997)](#167997)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T21:11:21Z","message":"[lens]
color mapping general ux fixes (#167997)\n\n## Summary\r\n\r\nFixes the
following issues with the Color mapping MVP
(see\r\n[here](https://github.com/elastic/kibana/issues/167506)):\r\n-
refactored the color contrast check and the RGB text input to
avoid\r\npopover flickering\r\n- replaced categorical/sequential icons
for color scales\r\n- add dot to complete the tooltip sentence.\r\n- fix
#167880 by adding a\r\ntooltip
to the warning
sign","sha":"6f62f7b5a65be6d99e9b3a0092304966b7a7bbf4","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.11.0","v8.12.0"],"number":167997,"url":"https://github.com/elastic/kibana/pull/167997","mergeCommit":{"message":"[lens]
color mapping general ux fixes (#167997)\n\n## Summary\r\n\r\nFixes the
following issues with the Color mapping MVP
(see\r\n[here](https://github.com/elastic/kibana/issues/167506)):\r\n-
refactored the color contrast check and the RGB text input to
avoid\r\npopover flickering\r\n- replaced categorical/sequential icons
for color scales\r\n- add dot to complete the tooltip sentence.\r\n- fix
#167880 by adding a\r\ntooltip
to the warning
sign","sha":"6f62f7b5a65be6d99e9b3a0092304966b7a7bbf4"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167997","number":167997,"mergeCommit":{"message":"[lens]
color mapping general ux fixes (#167997)\n\n## Summary\r\n\r\nFixes the
following issues with the Color mapping MVP
(see\r\n[here](https://github.com/elastic/kibana/issues/167506)):\r\n-
refactored the color contrast check and the RGB text input to
avoid\r\npopover flickering\r\n- replaced categorical/sequential icons
for color scales\r\n- add dot to complete the tooltip sentence.\r\n- fix
#167880 by adding a\r\ntooltip
to the warning
sign","sha":"6f62f7b5a65be6d99e9b3a0092304966b7a7bbf4"}}]}] BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
dej611 pushed a commit to dej611/kibana that referenced this issue Oct 17, 2023
@markov00 @dej611
[lens] color mapping general ux fixes (elastic#167997)
7b89b11 
## Summary

Fixes the following issues with the Color mapping MVP (see
[here](elastic#167506)):
- refactored the color contrast check and the RGB text input to avoid
popover flickering
- replaced categorical/sequential icons for color scales
- add dot to complete the tooltip sentence.
- fix elastic#167880 by adding a
tooltip to the warning sign
@stratoula stratoula mentioned this issue Dec 6, 2023
Closed
@gvnmagni gvnmagni self-assigned this May 30, 2024
@teresaalvarezsoler teresaalvarezsoler mentioned this issue Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvnmagni gvnmagni

Labels
Feature:Lens Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@markov00 @MichaelMarcialis @elasticmachine @gvnmagni