-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sticky KQL toolbar broken in Serverless #167908
Comments
Pinging @elastic/appex-sharedux (Team:SharedUX) |
The cause of the problem may come from the sticky_bar_broken_possible_cause.mov |
I took a quick look, the I think we will have to adjust it for serverless to account for
I am not sure if I am missing a simpler way |
@Dosant Your solution works 👏 If we were to go with this solution, would it be possible for sharedUX to provide an |
@semd, yes, I agree, we should expose something, I'll look into it. |
@Dosant Using the ESS (stateful) layout, we do not need to do any position changes when the top banner is present. Could it be that the serverless layout is doing something else differently that is causing all these positioning issues? |
Yes, the variable you're using changes depending on if the banner is present. |
## Summary - Fixes sticky kql bar in serverless security project #167908 - Fixes double scroll in serverless discover caused by incorrect app container height cc @elastic/kibana-data-discovery ![Screenshot 2023-10-10 at 17 23 58](https://github.com/elastic/kibana/assets/7784120/3bf50299-7d9f-4c38-953a-33a6a75815c6) - Fixes empty app header for top_nav component, for example, discover doc page: ![Screenshot 2023-10-10 at 17 24 45](https://github.com/elastic/kibana/assets/7784120/4965deac-9472-402f-8e8e-66ede83ce1bb) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co>
…68372) ## Summary - Fixes sticky kql bar in serverless security project elastic#167908 - Fixes double scroll in serverless discover caused by incorrect app container height cc @elastic/kibana-data-discovery ![Screenshot 2023-10-10 at 17 23 58](https://github.com/elastic/kibana/assets/7784120/3bf50299-7d9f-4c38-953a-33a6a75815c6) - Fixes empty app header for top_nav component, for example, discover doc page: ![Screenshot 2023-10-10 at 17 24 45](https://github.com/elastic/kibana/assets/7784120/4965deac-9472-402f-8e8e-66ede83ce1bb) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co>
Summary
The KQL toolbar is not sticky anymore in serverless.
Expected behavior
(in ESS)
sticky_bar_working.mov
Actual behavior
(in Serverless)
sticky_bar_not_working.mov
The text was updated successfully, but these errors were encountered: