Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Refactor ML job ID state management #171913

Open
miltonhultgren opened this issue Nov 24, 2023 · 2 comments
Open

[Infra] Refactor ML job ID state management #171913

miltonhultgren opened this issue Nov 24, 2023 · 2 comments
Labels
Feature:Logs ML Team:obs-ux-logs Observability Logs User Experience Team

Comments

@miltonhultgren
Copy link
Contributor

#168234 introduced a new part of the state used to generate the ID for the ML jobs for logs. This proved hard to test in an easy way so the tests introduced in that PR have been disabled.

Most likely the best solution to the issue is the refactor the state management used for the ML job IDs.
Rather than storing the ID format, the log view ID and the space ID and using those pieces to generate the ID in multiple places, we would store a full version of the ID or even the full ML job object and use that across the UI and the API requests.

Once that is done, the tests would need to be refactored but the same test cases should be easier to express in that world without having to rely on capturing network traffic.
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 24, 2023
@miltonhultgren miltonhultgren added Team:obs-ux-logs Observability Logs User Experience Team Team:obs-knowledge Observability Experience Knowledge team labels Nov 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 24, 2023
@miltonhultgren miltonhultgren mentioned this issue Nov 24, 2023
Merged
dej611 pushed a commit that referenced this issue Nov 24, 2023
@miltonhultgren
[infra] Disable flaky ML job ID format test suite (#171915)
f555dbe 
These tests rely on using browser performance timings to extract URLs
used when resolving ML job IDs to check if the right format is used and
updated when migrating to the new format.
Because this change is transparent to the user there isn't any way to
test the behaviour through UI elements and due to the structure of the
state management it's not straight forward to test it in isolation.

#171913 has been opened to
refactor the state management which should allow for this tests to be
updated and re-enabled.
@miltonhultgren miltonhultgren mentioned this issue Nov 28, 2023
Closed
@emma-raffenne emma-raffenne removed the Team:obs-knowledge Observability Experience Knowledge team label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Logs ML Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@miltonhultgren @gbamparop @elasticmachine @emma-raffenne