Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index filter cleared on index management page from version 8.11 onwards #173637

Closed
eyapene opened this issue Dec 19, 2023 · 1 comment · Fixed by #174515
Closed

Index filter cleared on index management page from version 8.11 onwards #173637

eyapene opened this issue Dec 19, 2023 · 1 comment · Fixed by #174515
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@eyapene
Copy link

eyapene commented Dec 19, 2023

Kibana version: 8.11.0

Describe the bug:
From version 8.11.0, in Stack Management > Index Management > Indices after filtering by name and clicking on the index name, a new page opens, instead of the modal window like in previous versions (related to #165705)
When Back to all indices is clicked, everything that was used to sort the indices is cleared and has to be typed in again.

Steps to reproduce:

  1. Go to Kibana > Stack Management > Index Management > Indices
  2. Filter indices by name
  3. Click on one of the filtered indices
  4. Click on Back to all indices to return to the Indices page

Expected behavior:
The filter value entered should be retained on the Indices page when you go back to the Indices page, as was the case in previous versions.

Screenshots (if relevant):
Capture d’écran 2023-12-19 à 15 20 32

Capture d’écran 2023-12-19 à 15 20 45 Capture d’écran 2023-12-19 à 15 20 55
@eyapene eyapene added bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI labels Dec 19, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 19, 2023
@dej611 dej611 added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Dec 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 20, 2023
yuliacech added a commit that referenced this issue Jan 18, 2024
…list (#174515)

## Summary

Fixes #173637 

This PR fixes a UX regression introduced in 8.11 by adding a new index
details page: the search value is lost when the user clicks the index
name and the index details page is opened. When they click the "back to
all indices" button, the search in the indices list is cleared.
To fix this issue, we need to store the data of the users' search,
toggles and pagination before opening the index details page so that
when going back to the indices list, these parameters could be restored
in the table. This PR adds these parameters to the url when the index
page is opened and when navigating back, the indices list is initialized
with this data.
Since the toggles of the indices list can be added dynamically via the
extensions service, there logic for storing this data needs to be
dynamic as well. For a cleaner solution, I decided to move the "include
hidden indices" toggle to the extensions service as well, since the
logic of this toggle is exactly the same as the one for "include rollup
indices" toggle for example. This caused a minor change in the UI: the
rollup and hidden indices toggles are now displayed in the reversed
order.

### Screenshot 
<img width="916" alt="Screenshot 2024-01-11 at 14 38 22"
src="https://github.com/elastic/kibana/assets/6585477/e7174909-0a68-4041-94a2-2d1646eae0fe">


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
yuliacech added a commit to yuliacech/kibana that referenced this issue Jan 26, 2024
…list (elastic#174515)

## Summary

Fixes elastic#173637

This PR fixes a UX regression introduced in 8.11 by adding a new index
details page: the search value is lost when the user clicks the index
name and the index details page is opened. When they click the "back to
all indices" button, the search in the indices list is cleared.
To fix this issue, we need to store the data of the users' search,
toggles and pagination before opening the index details page so that
when going back to the indices list, these parameters could be restored
in the table. This PR adds these parameters to the url when the index
page is opened and when navigating back, the indices list is initialized
with this data.
Since the toggles of the indices list can be added dynamically via the
extensions service, there logic for storing this data needs to be
dynamic as well. For a cleaner solution, I decided to move the "include
hidden indices" toggle to the extensions service as well, since the
logic of this toggle is exactly the same as the one for "include rollup
indices" toggle for example. This caused a minor change in the UI: the
rollup and hidden indices toggles are now displayed in the reversed
order.

### Screenshot
<img width="916" alt="Screenshot 2024-01-11 at 14 38 22"
src="https://github.com/elastic/kibana/assets/6585477/e7174909-0a68-4041-94a2-2d1646eae0fe">

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 953c92f)

# Conflicts:
#	x-pack/plugins/index_management/public/application/sections/home/index_list/details_page/details_page.tsx
#	x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js
#	x-pack/plugins/index_management/public/services/extensions_service.ts
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
…list (elastic#174515)

## Summary

Fixes elastic#173637 

This PR fixes a UX regression introduced in 8.11 by adding a new index
details page: the search value is lost when the user clicks the index
name and the index details page is opened. When they click the "back to
all indices" button, the search in the indices list is cleared.
To fix this issue, we need to store the data of the users' search,
toggles and pagination before opening the index details page so that
when going back to the indices list, these parameters could be restored
in the table. This PR adds these parameters to the url when the index
page is opened and when navigating back, the indices list is initialized
with this data.
Since the toggles of the indices list can be added dynamically via the
extensions service, there logic for storing this data needs to be
dynamic as well. For a cleaner solution, I decided to move the "include
hidden indices" toggle to the extensions service as well, since the
logic of this toggle is exactly the same as the one for "include rollup
indices" toggle for example. This caused a minor change in the UI: the
rollup and hidden indices toggles are now displayed in the reversed
order.

### Screenshot 
<img width="916" alt="Screenshot 2024-01-11 at 14 38 22"
src="https://github.com/elastic/kibana/assets/6585477/e7174909-0a68-4041-94a2-2d1646eae0fe">


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants