Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]User is able to attach a duplicate timeline to a Case without Saving the timeline. #174733

Open
sukhwindersingh-qasource opened this issue Jan 12, 2024 · 10 comments
Open

[Security Solution]User is able to attach a duplicate timeline to a Case without Saving the timeline. #174733

sukhwindersingh-qasource opened this issue Jan 12, 2024 · 10 comments
Assignees
@janmonschke
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0

Comments

@sukhwindersingh-qasource
Copy link

sukhwindersingh-qasource commented Jan 12, 2024 •
edited
Loading

Describe the bug:
User is able to attach a duplicate timeline to a Case without Saving the timeline

Kibana/Elasticsearch Stack version

VERSION: 8.12.0 BC5
BUILD: 70053
COMMIT: db9b892

Browser and Browser OS Version:
Firefox for windows OS
Version: 121.0

Elastic Endpoint Version:
N/A

Original install method:
None

Functional Area:
Timeline

Initial Setup:

  • None

Precondition

  • Saved timeline should be present on Timelines page

Steps to reproduce

  • Go to Security timeline
  • Click on the more options of the saved timeline.
  • Select Duplicate timeline
  • Now click attach to case button.
  • Attach the time to a new case or existed case

Actual Result :

  • User is able to attach a duplicate timeline to a Case without Saving the timeline.

Expected Result :

  • Duplicate timeline should not be attached to a case unless it is saved.

Additional Information

  • While adding duplicate timeline without saving it shows error no timeline id found
    image

Screen-Cast :

Timelines.-.Kibana.Mozilla.Firefox.2024-01-12.11-17-34.mp4
@sukhwindersingh-qasource sukhwindersingh-qasource added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0 labels Jan 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@sukhwindersingh-qasource
Copy link
Author

@manishgupta-qasource Kindly review this
Thanks !

@manishgupta-qasource
Copy link

Reviewed and assigned to @MadameSheema

@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels Jan 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@sukhwindersingh-qasource sukhwindersingh-qasource changed the title [Security Solution]User is able to attach a timeline to a Case without Saving the timeline. [Security Solution]User is able to attach a duplicate timeline to a Case without Saving the timeline. Jan 15, 2024
@michaelolo24
Copy link
Contributor

This makes sense as the timeline had not been saved yet. @janmonschke, do you think we should disable certain actions until we can verify the timeline has been saved? Thanks!

@PhilippeOberti
Copy link
Contributor

This makes sense as the timeline had not been saved yet. @janmonschke, do you think we should disable certain actions until we can verify the timeline has been saved? Thanks!

Chiming in as I fixed a similar bug (PR) a few weeks ago where users could favorite an unsaved timeline. I decided to prevent users from favoriting until the timeline would be saved.
I feel like we need to be consistent as much as possible

@janmonschke
Copy link
Contributor

This makes sense as the timeline had not been saved yet. @janmonschke, do you think we should disable certain actions until we can verify the timeline has been saved? Thanks!

Yep, that would make sense

@logeekal
Copy link
Contributor

logeekal commented Oct 7, 2024

@janmonschke , Do you remember if you already worked on this bug?

@janmonschke
Copy link
Contributor

@logeekal I did not work on this yet, iirc

@logeekal logeekal removed their assignment Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janmonschke janmonschke

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@janmonschke @logeekal @elasticmachine @michaelolo24 @PhilippeOberti @MadameSheema @manishgupta-qasource @muskangulati-qasource @sukhwindersingh-qasource