[Security Solution][Timeline] fix timeline favorite working for draft timeline

[PhilippeOberti]

Summary

I discovered a bug today where users can click on the favorite button both in the bottom bar and in the timeline modal header even if the timeline hasn't been saved.
This PR fixes that while also doing small amount of refactor:

• extract the AddToFavoriteButton component out of the helpers.tsx file and move the AddToFavoriteButton component to its own folder at the root of the components folder as it's used in the bottom bar and the modal header
• clean the AddToFavoriteButton component by removing the compact mode which isn't used, using a proper selector to retrieve data from the redux store
• refactor and improve the unit test to use React testing-library instead of enzyme

Screen.Recording.2024-01-18.at.4.43.32.PM.mov

Checklist

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

[janmonschke]

Great improvements!

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 9b95eae

Failed CI Steps

• FTR Configs #14

Test Failures

• [job] [logs] FTR Configs #14 / endpoint Endpoint Exceptions should NOT add event.module=endpoint to entry if there is another operator

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
securitySolution	4875	4876	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	11.1MB	11.1MB	-822.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
securitySolution	469	470	+1

Total ESLint disabled count

id	before	after	diff
securitySolution	541	542	+1

History

• 💔 Build #188564 failed 3bfdc678cf7b6a3733787d1185f0a802dbe3ad43
• 💔 Build #188562 failed f2f783aec4e1a671ed147ddc5b5a30d976bb813e
• 💔 Build #188556 failed 6045a1700b05694f5bbb0fce62ac814a2fe56187

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream