[Security Solution][Timeline] fix wrong add to favorite within timeline guided tour #175993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
force-pushed
the
fix-timeline-tour-favorite
branch
2 times, most recently
from
5b80a87 to
b8afd14
Compare
PhilippeOberti
force-pushed
the
fix-timeline-tour-favorite
branch
from
b8afd14 to
b241037
Compare
kqualters-elastic
approved these changes
Jan 31, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the timeline guided tour. The bug must have been introduced in this refactor PR, but looking at the prior code, I'm not sure how things were correctly working before. We already had the favorite button shared and both had the same id...
The code is now working correctly
Screen.Recording.2024-01-31.at.9.00.11.AM.mov
Notes: I decided to use a
isPartOfGuidedTour: booleanprop but originally had a different idea: using something likeguidedTourId: string(guidedTourIdwould be the actual tour id). I didn't like the fact that the parent component had to know about that information though, so decided against it. If you think this would be better I'll make the change!#175952
TODO:
Checklist