-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] EuiDataGrid cellActions not working in Explore pages. #177410
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
These tables have not received any change recently, and considering the problem is fixed by removing a piece of code that has existed for the last 15 months, it is very likely the bug has been introduced by some change in EUI (EUI PRs) |
Pinging @elastic/eui-team (EUI) |
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
I tested different commits and I confirmed the bug was introduced in 7357af5 by EUI update to v91.3.1 |
Hey Sergi - line 413 (
|
## Summary issue: elastic#177410 Adding `overflow: hidden` style was causing the cell actions to disappear after the upgrade to [EUI upgrade to v91.3.1](elastic#173569) The `overflow: hidden` style is no longer needed, it has been removed. So cell actions are displayed (cherry picked from commit ab864b4)
#177501) # Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution] Fix cell actions in Explore pages (#177478)](#177478) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2024-02-21T17:52:45Z","message":"[Security Solution] Fix cell actions in Explore pages (#177478)\n\n## Summary\r\n\r\nissue: https://github.com/elastic/kibana/issues/177410\r\n\r\nAdding `overflow: hidden` style was causing the cell actions to\r\ndisappear after the upgrade to [EUI upgrade to\r\nv91.3.1](https://github.com/elastic/kibana/pull/173569)\r\n\r\nThe `overflow: hidden` style is no longer needed, it has been removed.\r\nSo cell actions are displayed","sha":"ab864b4ccc699cc1a986bf099460ad877a42333d","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat Hunting","Team:Threat Hunting:Explore","v8.13.0","v8.14.0"],"title":"[Security Solution] Fix cell actions in Explore pages","number":177478,"url":"https://github.com/elastic/kibana/pull/177478","mergeCommit":{"message":"[Security Solution] Fix cell actions in Explore pages (#177478)\n\n## Summary\r\n\r\nissue: https://github.com/elastic/kibana/issues/177410\r\n\r\nAdding `overflow: hidden` style was causing the cell actions to\r\ndisappear after the upgrade to [EUI upgrade to\r\nv91.3.1](https://github.com/elastic/kibana/pull/173569)\r\n\r\nThe `overflow: hidden` style is no longer needed, it has been removed.\r\nSo cell actions are displayed","sha":"ab864b4ccc699cc1a986bf099460ad877a42333d"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177478","number":177478,"mergeCommit":{"message":"[Security Solution] Fix cell actions in Explore pages (#177478)\n\n## Summary\r\n\r\nissue: https://github.com/elastic/kibana/issues/177410\r\n\r\nAdding `overflow: hidden` style was causing the cell actions to\r\ndisappear after the upgrade to [EUI upgrade to\r\nv91.3.1](https://github.com/elastic/kibana/pull/173569)\r\n\r\nThe `overflow: hidden` style is no longer needed, it has been removed.\r\nSo cell actions are displayed","sha":"ab864b4ccc699cc1a986bf099460ad877a42333d"}}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
## Summary issue: elastic#177410 Adding `overflow: hidden` style was causing the cell actions to disappear after the upgrade to [EUI upgrade to v91.3.1](elastic#173569) The `overflow: hidden` style is no longer needed, it has been removed. So cell actions are displayed
Describe the bug:
Cell actions are not displayed in the Events tables of Explore pages.
Kibana/Elasticsearch Stack version:
8.13
Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Explore pages
Steps to reproduce:
Current behavior:
Cell actions do not appear
Expected behavior:
Cell actions appear
Screenshots (if relevant):
Cell actions are displayed in Alerts table but not in Events table
cell_actions_explore_not_showing.mov
Any additional context (logs, chat logs, magical formulas, etc.):
Removing/commenting all the
setCellProps
calls (or the entireuseEffect
) in therenderCellValue
function prop ofEuiDataGrid
component, fixes the problem and all cell actions appear correctly.kibana/x-pack/packages/security-solution/data_table/components/data_table/index.tsx
Lines 412 to 421 in 74a248b
The text was updated successfully, but these errors were encountered: