[Discover][ES|QL] Legacy table should not be rendered for ES|QL mode

[jughosta]

Only the data grid has full support for ES|QL mode. The legacy table might be lacking some features (like in-memory sorting) as it was not extended to account for ES|QL.

Even if user has doc_table:legacy Advanced Setting enabled, the legacy table should not be rendered for text based queries.

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[elasticmachine]

Pinging @elastic/kibana-esql (Team:ESQL)

[stratoula]

Yes I agree, let's remove it. Can we possibly do it before 8.14 release? Is it a big feature? I am asking mostly due to going on GA on 8.14 cc @davismcphee

[jughosta]

I think we should replace all uiSettings.get(DOC_TABLE_LEGACY) with a new wrapper function. Something like

// in `@kbn/discover-utils` package

export function isLegacyTableEnabled(uiSettings, isTextBased) {
  if (isTextBased) {
     return false;
  }
  
  return uiSettings.get(DOC_TABLE_LEGACY);
}

So we can handle it discover, doc viewer etc in the same way.

[davismcphee]

Yes, this makes sense to me, and the solution proposed by @jughosta sounds like a good one! It seems like a small change to me, although we're trying to wrap up a few other things before 8.14 FF currently. @stratoula should we do this before continuing work on #180249? If so, maybe @jughosta could take this one on.

[stratoula]

@davismcphee I was thinking that maybe it worth prioritizing this instead of the suggestions dropdown.

• It will def make it for 8.14 while the other most possibly not
• As we are going on GA, I think is better to remove it now rather later.

So if you are also ok with this, let's go with this first

[davismcphee]

@stratoula Agreed, this makes sense so let's do it! Although I see from the linked PR @jughosta is already on top of it 😄