-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Legacy metrics display changes #189628
Labels
Feature:ObsHosts
Hosts feature within Observability
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
technical debt
Improvement of the software architecture and operational architecture
Comments
crespocarlos
added
the
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
label
Jul 31, 2024
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
crespocarlos
added
needs-team
Issues missing a team label
Feature:ObsHosts
Hosts feature within Observability
labels
Jul 31, 2024
crespocarlos
changed the title
[infra] Legacy metrics in Inventory UI and Alert flyout display changes
[infra] Legacy metrics display changes
Jul 31, 2024
smith
added
the
technical debt
Improvement of the software architecture and operational architecture
label
Jul 31, 2024
jennypavlova
added a commit
that referenced
this issue
Aug 13, 2024
Closes #189628 Closes #190118 ## Summary This PR changes the way we show the legacy metrics. It changes the hosts table `rx` and `tx` values to use the `v2` and renames `availablefieldsOptions` to `availableFieldsOptions` It covers `1.` and `2.` from this [comment](#189261 (review)) ## Testing: Legacy metrics changes in inventory https://github.com/user-attachments/assets/d2a74b0f-8a63-49f2-8d4b-e9c738440609 The legacy metrics are currently visible only for hosts so in other asset types they should not be visible (Inventory + Alerts) <img width="1624" alt="Screenshot 2024-08-06 at 14 34 49" src="https://github.com/user-attachments/assets/b24df6b1-5a0d-4a01-ac88-412a419c5d6c"> Alert rules creation and metrics drop-down (with/without legacy metric) https://github.com/user-attachments/assets/a403c96a-764d-4451-b370-e05a9ae1c5b4 On the Alerts page when creating a rule the default metric is CPU Usage (not the legacy one): ![image](https://github.com/user-attachments/assets/08ed4a7a-6f6c-4aa2-8f10-5b76d6e84ea6) Align CPU usage (Legacy) label and position with RX / TX metrics: <img width="1415" alt="image" src="https://github.com/user-attachments/assets/2ce9269e-6f88-47ca-b76c-105f1daab152">
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this issue
Aug 13, 2024
Closes elastic#189628 Closes elastic#190118 ## Summary This PR changes the way we show the legacy metrics. It changes the hosts table `rx` and `tx` values to use the `v2` and renames `availablefieldsOptions` to `availableFieldsOptions` It covers `1.` and `2.` from this [comment](elastic#189261 (review)) ## Testing: Legacy metrics changes in inventory https://github.com/user-attachments/assets/d2a74b0f-8a63-49f2-8d4b-e9c738440609 The legacy metrics are currently visible only for hosts so in other asset types they should not be visible (Inventory + Alerts) <img width="1624" alt="Screenshot 2024-08-06 at 14 34 49" src="https://github.com/user-attachments/assets/b24df6b1-5a0d-4a01-ac88-412a419c5d6c"> Alert rules creation and metrics drop-down (with/without legacy metric) https://github.com/user-attachments/assets/a403c96a-764d-4451-b370-e05a9ae1c5b4 On the Alerts page when creating a rule the default metric is CPU Usage (not the legacy one): ![image](https://github.com/user-attachments/assets/08ed4a7a-6f6c-4aa2-8f10-5b76d6e84ea6) Align CPU usage (Legacy) label and position with RX / TX metrics: <img width="1415" alt="image" src="https://github.com/user-attachments/assets/2ce9269e-6f88-47ca-b76c-105f1daab152">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:ObsHosts
Hosts feature within Observability
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
technical debt
Improvement of the software architecture and operational architecture
Summary
Following up the work done on #188641 and #188634:
We want to position the all legacy metrics (
cpu
,rx
,tx
) at the bottom of the Inventory metrics dropdown list (but above custom metrics)all metrics (legacy included) need to be displayed on the tooltip - legacy ones at the bottom, similar to the dropdown
On the alert flyout, by default we won't show the legacy metrics
The legacy metrics will only be available in the dropdown, if the flyout is opened with one of them preselected
AC
The text was updated successfully, but these errors were encountered: