Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Rison URL should fatal #2103

Closed
w33ble opened this issue Dec 4, 2014 · 1 comment · Fixed by #2173
Closed

Invalid Rison URL should fatal #2103

w33ble opened this issue Dec 4, 2014 · 1 comment · Fixed by #2173
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience PR sent

Comments

@w33ble
Copy link
Contributor

w33ble commented Dec 4, 2014

Related to #1553

When sharing a Kibana link with someone, if it gets truncated, the rison part end up no longer being valid, but the URL is still perfectly valid itself. So, the app loads, rison errors silently, and the user is left staring at a mostly blank screen. What's worse is that whatever app the user was sent to is now stuck in that broken state, with no way to reset their app state and move along!

screenshot 2014-12-03 19 15 59

Here's an example URL, for reference, as sent to me over Hipchat

http://localhost:8000/#/visualize/create?type=line&indexPattern=%5Blogstash-%5DYYYY.MM.DD&_g=()&_a=(query:(query_string:(query:'*')),vis:(aggs:!((id:1,params:(),schema:metric,type:count),(id:4,params:(field:_type,order:desc,row:!t,size:5),schema:split,type:terms),(id:2,params:(extended_bounds:(),field:'@timestamp',interval:auto,min_doc_count:1),schema:segment,type:date_histogram),(id:3,params:(field:extension,order:desc,size:5),schema:group,type:terms),(id:5,params:(field:bytes),schema:metric,type:avg)),listeners:(),params:(addLegend:!t,addTooltip:!t,shareYAxis:!t,spyPerPage:10),type:line

What should happen? Most likely, Kibana should show the end user a message saying that the URL they were sent is invalid, and the app state should be emptied/reset.

@w33ble w33ble added the bug Fixes for quality problems that affect the customer experience label Dec 4, 2014
@rashidkpc
Copy link
Contributor

Agreed, should definitely fatal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience PR sent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants