Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] "Point to Point" Data Source #41575

Closed
alexfrancoeur opened this issue Jul 19, 2019 · 8 comments
Closed

[Maps] "Point to Point" Data Source #41575

alexfrancoeur opened this issue Jul 19, 2019 · 8 comments
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation discuss enhancement New value added to drive a business result

Comments

@alexfrancoeur
Copy link

As we begin talks with the SIEM team around a pew pew map (SHIELDS! 😆 ) and explore potentially handling this type of map on the client rather than using a geo_shape LineString (elastic/beats#11702) in Elasticsearch, I thought it'd be interesting to consider this type of map as a generic data source. ECS has standardized numerous geo_points in the same document, so it's possible that this could become a common ask.

image

Screen Shot 2019-07-19 at 9 39 33 AM

So rather than having three layers to build a map like this, you'd be able to condense into a single layer and aggregate on common paths.

maps_siem

This type of layer would end up looking similar to @nreese's POC #41504. I'm guessing the behavior would be similar to a document layer as far as global and layer filtering goes. We could potentially style each point as well as the line and offer a customize-able (but capped) destinations. This is just a concept at the moment, but would love to get some feedback from the group and our community. I could see this being useful for Elastic APM RUM maps, tracking origin / destination on things like flight patterns or package deliveries, etc.

cc: @tsg @MikePaquette @spong @thomasneirynck

@alexfrancoeur alexfrancoeur added discuss [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result labels Jul 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@nreese
Copy link
Contributor

nreese commented Jul 19, 2019

So rather than having three layers to build a map like this, you'd be able to condense into a single layer and aggregate on common paths

I don't think the source should provide all three features. Instead, the source would just provide a client-side generated line between two points

The reason the source should not also include the source and destination points is because it would make styling more complicated. Style settings would have to be nested for each part: source point, destination point, and connection line. Also, what would the legend icon be for a source that has three separate styling blocks?

I think we should always consider a source/layer as returning a single data set with a single styling.

Then we could work on grouping layers to declutter/organize the legend as suggested in #37252

@alexfrancoeur
Copy link
Author

++ that works for me, agreed that the nested styling would add additional complexity and I like the concept of grouping layers. I've heard this request a few times now.

@alexfrancoeur
Copy link
Author

Do we need to involve design here at all for this data source? If so, it's probably a minimal need. I'm not sure if we need a separate icon for this new type of data source. As far as the input goes, I'd imagine you select an index pattern and then choose two IP's in your document. A source / origin and a destination. Are there any limitations as far as styling goes?

Separately, naming for this type of data source will be interested. Brain dump below, open to any thoughts / feedback

@nreese
Copy link
Contributor

nreese commented Aug 19, 2019

I like "point to point" best as its the most descriptive to what the source is doing.

The problem with flow is that is more of region to region map, showing data from one region migrating to another region. I think we may want a flow map in the future that behaves more like the "term joins" today and uses a term aggregation to derive the metrics and looks up a path between the matching regions.

@alexfrancoeur
Copy link
Author

Updating the title to "Point to point" for now

@alexfrancoeur alexfrancoeur changed the title [Maps] Source & Destination Data Source [Maps] "Point to Point" Data Source Aug 28, 2019
@alexfrancoeur
Copy link
Author

Just noticed this is in master, are we good to close now @nreese?

@nreese
Copy link
Contributor

nreese commented Aug 29, 2019

closed by #41504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation discuss enhancement New value added to drive a business result
Projects
None yet
Development

No branches or pull requests

3 participants