-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] New platform migration: replace injected vars #44232
Comments
Pinging @elastic/apm-ui |
There's some additions in #46497. Search for |
Asked @joshdover about what we should use to replace this. He wrote:
Putting this ticket back in the backlog. |
Labelling as blocked by #41990. |
Want to point out that we have exposed the old |
@joshdover Instead of using the inject stuff we might just make an endpoint like |
That's certainly an option, but will slow down the startup of Kibana or
your application. In fact, if you're doing this in setup or start, this may
become impossible depending on if we accept this RFC:
#45796
I think if you're blocked right now, it's significantly less work to use
`getInjectedVar` until the real solution is finished.
…On Mon, Nov 11, 2019 at 1:27 PM Søren Louv-Jansen ***@***.***> wrote:
@joshdover <https://github.com/joshdover> Instead of using the inject
stuff we might just make an endpoint like GET /api/apm/config that
returns a whitelist of config options. WDYT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44232?email_source=notifications&email_token=AAN2UEBL7PGVJILG4QCOBDLQTGWZ5A5CNFSM4IRCBK62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDX3FLY#issuecomment-552579759>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN2UECHLL6RD5JR2EC7IELQTGWZ5ANCNFSM4IRCBK6Q>
.
|
PR: Expose whitelisted config values to client-side plugin #50641 |
We rely on injected var in a number of places:
apmUiEnabled
- inpublic/hacks/toggle_app_link_in_nav.ts
,public/register_feature.js
apmIndexPatternTitle
- inpublic/components/app/ServiceDetails/ServiceIntegrations/WatcherFlyout.tsx
apmServiceMapEnabled
inpublic/components/app/ServiceDetails/ServiceDetailTabs.tsx
,public/components/app/Main/route_config/index.tsx
,public/components/app/Home/index.tsx
Related Platform Issue: #41990
Follow the details outlined in the platform PR #50641 to define a set of whitelisted configs that can be referenced from the client.
The text was updated successfully, but these errors were encountered: