Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] NP migration replace ui/kfetch with core.http #46548

Closed
ogupte opened this issue Sep 25, 2019 · 1 comment · Fixed by #47635
Closed

[APM] NP migration replace ui/kfetch with core.http #46548

ogupte opened this issue Sep 25, 2019 · 1 comment · Fixed by #47635
Assignees
@dgieselaar
Labels
Team:APM All issues that need APM UI Team support v7.5.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Sep 25, 2019

We use kfetch on the client-side for calling kibana APIs public/services/rest/callApi.ts. We also use it to define some types in routes as well as mocks in tests. replace these uses of kfetch with the core.http API.
@ogupte ogupte added [zube]: Inbox Team:APM All issues that need APM UI Team support labels Sep 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@jasonrhodes jasonrhodes mentioned this issue Sep 25, 2019
Closed
12 tasks
@dgieselaar dgieselaar self-assigned this Oct 4, 2019
@dgieselaar dgieselaar mentioned this issue Oct 8, 2019
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Oct 11, 2019
@dgieselaar
[APM] Replace ui/kfetch with core.http
457d961 
Closes elastic#46548.
dgieselaar added a commit that referenced this issue Oct 11, 2019
@dgieselaar
[APM] Replace ui/kfetch with core.http (#47635)
819f334 
* [APM] Replace ui/kfetch with core.http

Closes #46548.

* Remove kfetch mocks in tests

* Expose HttpFetchError from src/core/public/index

* Make HttpFetchError public

* Simplify tests for ServiceOverview
@zube zube bot reopened this Oct 11, 2019
dgieselaar added a commit that referenced this issue Oct 15, 2019
@dgieselaar
[7.x] [APM] Replace ui/kfetch with core.http (#47635) (#48211)
cf7f2aa 
* [APM] Replace ui/kfetch with core.http

Closes #46548.

* Remove kfetch mocks in tests

* Expose HttpFetchError from src/core/public/index

* Make HttpFetchError public

* Simplify tests for ServiceOverview
@jasonrhodes jasonrhodes mentioned this issue Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
Team:APM All issues that need APM UI Team support v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Replace ui/kfetch with core.http dgieselaar/kibana
4 participants
@sorenlouv @dgieselaar @ogupte @elasticmachine