Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary x-pack/legacy/plugins/infra eslint overrides #49563

Closed
spalger opened this issue Oct 28, 2019 · 1 comment · Fixed by #50979
Closed

Remove temporary x-pack/legacy/plugins/infra eslint overrides #49563

spalger opened this issue Oct 28, 2019 · 1 comment · Fixed by #50979
Assignees
@weltenwort
Labels
chore Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019 •
edited
Loading

In order to move forward with #49244 we needed to disable some rules in x-pack/legacy/plugins/infra. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['x-pack/legacy/plugins/infra/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
    'react-hooks/rules-of-hooks': 'off',
  },
},
@spalger spalger added the chore label Oct 28, 2019
@spalger spalger mentioned this issue Oct 28, 2019
Open
31 tasks
@timroes timroes added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort self-assigned this Nov 18, 2019
This was referenced Nov 18, 2019
Closed
Merged
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature labels Nov 18, 2019
weltenwort added a commit that referenced this issue Dec 11, 2019
@weltenwort
[Logs + Metrics UI] Remove eslint exceptions (#50979)
0cd62ca 
This removes the two eslint exceptions specific to the `infra` plugin introduced in #49244.

fixes #49563
weltenwort added a commit to weltenwort/kibana that referenced this issue Dec 12, 2019
@weltenwort
[Logs + Metrics UI] Remove eslint exceptions (elastic#50979)
6d3e729 
This removes the two eslint exceptions specific to the `infra` plugin introduced in elastic#49244.

fixes elastic#49563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
chore Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs + Metrics UI] Remove eslint exceptions weltenwort/kibana
5 participants
@sgrodzicki @timroes @weltenwort @spalger @elasticmachine