Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Refactor ML job management hooks to be module-agnostic #50322

Closed
weltenwort opened this issue Nov 12, 2019 · 1 comment · Fixed by #50662
Closed

[Logs UI] Refactor ML job management hooks to be module-agnostic #50322

weltenwort opened this issue Nov 12, 2019 · 1 comment · Fixed by #50662
Assignees
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0

Comments

@weltenwort
Copy link
Member

Summary

The React hook useLogAnalysisJobs is currently coupled to the log entry rate analysis job. Since the management tasks required to match the upcoming log category analysis job are mostly identical, this hook should be prepared for re-use with that module.

Acceptance criteria

  • The useLogAnalysisJobs hook is parameterized so it can manage various ML modules, in particular
    • the module name
    • the jobs list
    • the api calls performed to set up the module
    • the configuration check performed to verify job consistency
    • the validation route called to validate the setup parameters
  • A new log entry rate hook exists, which is a slim wrapper around the generic job management hook with specific parameters.
@weltenwort weltenwort added [zube]: Backlog Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 labels Nov 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort changed the title [Logs UI] Refactor ml job management hooks to be module-agnostic [Logs UI] Refactor ML job management hooks to be module-agnostic Nov 12, 2019
@weltenwort weltenwort self-assigned this Nov 13, 2019
@zube zube bot unassigned weltenwort Nov 13, 2019
@weltenwort weltenwort self-assigned this Nov 18, 2019
weltenwort added a commit that referenced this issue Dec 10, 2019
This abstracts the specific job details out of the ML module management hooks to enable re-use with the upcoming categorization module.

closes #50322
weltenwort added a commit to weltenwort/kibana that referenced this issue Dec 11, 2019
This abstracts the specific job details out of the ML module management hooks to enable re-use with the upcoming categorization module.

closes elastic#50322
weltenwort added a commit to weltenwort/kibana that referenced this issue Dec 11, 2019
This abstracts the specific job details out of the ML module management hooks to enable re-use with the upcoming categorization module.

closes elastic#50322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants