Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] (Accessibility) Heading structure #52278

Closed
18 tasks done
peteharverson opened this issue Dec 5, 2019 · 5 comments
Closed
18 tasks done

[ML] (Accessibility) Heading structure #52278

peteharverson opened this issue Dec 5, 2019 · 5 comments

Comments

@peteharverson
Copy link
Contributor

peteharverson commented Dec 5, 2019

Per #37539, all of the Machine Learning pages need to be audited to ensure headers are being used appropriately.

Known issues from the audit of other plugins include:

  • Main landmark must not be contained in another landmark
  • Document must have 1 main landmark
  • Ensure landmarks are unique
  • Every page should have an <h1>
  • Heading tags should be properly nested e.g. <h1> - <h2> - <h3>

Relevant WCAG Criteria: [#.#.# WCAG Criterion - Level A/AA/AAA](link to https://www.w3.org/WAI/WCAG21/quickref/)

Relevant ARIA spec: [](link to https://www.w3.org/TR/wai-aria-practices/)

Changes required to ML plugin:

  • Overview page - convert 'Getting started' to an <h1>
  • Anomaly job list - add <main> landmark (e.g. wrap in <EuiPage>
  • Select anomaly job type page - convert title to an <h1>
  • Create anomaly job wizard - convert title to an <h1>
  • Anomaly Explorer - add <main> landmark (e.g. wrap in <EuiPage>, and an <h1> page title
  • Single Metric Viewer - add <main> landmark (e.g. wrap in <EuiPage>, and an <h1> page title
  • Settings page - convert title to an <h1>
  • Calendars List page - add <main> landmark (e.g. add <EuiPageBody>
  • Edit calendar page - add <main> landmark (e.g. add <EuiPageBody>
  • Filter List page - add <main> landmark (e.g. add <EuiPageBody>
  • Edit filter list page - add <main> landmark (e.g. add <EuiPageBody>
  • Data Visualizer - select index or file - convert title to an <h1>
  • File Data Visualizer - select file page - convert title to an <h1>
  • File Data Visualizer - summary page - add <main> landmark (e.g. wrap in <EuiPage>, and an <h1> page title
  • File Data Visualizer - import data page - add <main> landmark (e.g. wrap in <EuiPage>, and convert title to an <h1>
  • Data Visualizer - skipped heading levels (card sub-headings, create job link cards)

Pages already meet criteria:

  • Select index or search page
  • Analytics job list
  • Analytics job results page
  • Access denied page

Changes required to Transforms plugin:

  • Transforms list page - duplicate <main> landmarks
  • Create Transform page - duplicate <main> landmarks
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@rayafratkina
Copy link
Contributor

@peteharverson is this still planned for 7.6?

@peteharverson
Copy link
Contributor Author

@rayafratkina yes I am currently checking what, if anything, needs fixing on the ML pages. If only minor changes are required, I'm still planning on getting this in for 7.6.

@peteharverson
Copy link
Contributor Author

Audited all the pages in the ML and Transforms plugin, with notes on what needs to be done for each page added to the description above.

@rayafratkina, due to the scope of changes that are required, I am pushing this to 7.7.

@peteharverson
Copy link
Contributor Author

Closing, fixed by #56741 and #56883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants