Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] color mismatch in 7.5.0 #52846

Closed
TomonoriSoejima opened this issue Dec 12, 2019 · 5 comments
Closed

[TSVB] color mismatch in 7.5.0 #52846

TomonoriSoejima opened this issue Dec 12, 2019 · 5 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@TomonoriSoejima
Copy link
Contributor

Kibana version: 7.5

Elasticsearch version: 7.5

Server OS version:

Browser version:

Version 78.0.3904.108 (Official Build) (64-bit)

Browser OS version:

Darwin nami.local 19.2.0 Darwin Kernel Version 19.2.0: Sat Nov 9 03:47:04 PST 2019; root:xnu-6153.61.1~20/RELEASE_X86_64 x86_64

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

The color on the chart remains unchanged.

Steps to reproduce:

  1. push the sample data to both 7.4.0 and 7.5.0
    data.zip

curl -H 'Content-Type: application/x-ndjson' -XPOST 'localhost:9200/_bulk?pretty' --data-binary @data.json

This will create an index named hotel.
So make an index pattern for that

  1. create TSVB by mimicking the setting below
  2. And drag around the DATA between CANADA, INDIA and JAPAN and note that the chart color appeared fix in pink which is the color of INDIA

image

Doing the same in 7.4.0 will change the color accordingly, thus it appears a bug in 7.5.0

Screenshots (if relevant):
See that the chart color is Yellow on the left (7.4.0) while it is Pink on the right (7.5.0).
I expected the both color to be Yellow for the chosen country CANADA

7 4 left 7 5 right

**Errors in browser console (if relevant):**

Provide logs and/or server output (if relevant):

Any additional context:

@Bargs Bargs added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@markov00 markov00 added the Feature:ElasticCharts Issues related to the elastic-charts library label Dec 18, 2019
@markov00
Copy link
Member

Hi @TomonoriSoejima there was a change on the rendering library for the charts in TSVBV between 7.4 and 7.5.
The bug highlighted here is that the rendering order is not respected, it should respect the order of the series, instead it respect the order of the creation of the series:
for example if you create 3 series in sequence (A,B,C => green, red, blue) the last rendered series is the C and the prevalent color is blue (all the others are underneath with a small transparency). But then if you move the C-Blue series to the top (C,B,A) the rendering still keep the original order with the last series rendered blue.

In 7.4 the rendering shows happens in a bottom-up order (the first bar on the top of the list is rendered as the latest and will result on the top all all the others). In 7.5 the order is weirdly respected: the order is inverted and, if manually sorted, it keep using the creation order.

@markov00 markov00 self-assigned this Dec 18, 2019
@markov00 markov00 added bug Fixes for quality problems that affect the customer experience triaged labels Dec 18, 2019
@markov00
Copy link
Member

I've just checked that, refreshing the page, the order of the series is then correctly respected (still the inverse of the one in 7.4)

@timroes
Copy link
Contributor

timroes commented Aug 20, 2020

@markov00 The linked PR states that this should be fixed in elastic-charts. Do you know if this is fixed already and can be closed?

@TomonoriSoejima
Copy link
Contributor Author

Yes we can close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants