Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Fix series rendering order #53488

Closed

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Dec 18, 2019

Summary

We switched the implementation of TSVB rendering library between 7.4 and 7.5. Unfortunately the rendering order of the series wasn't fully respected in this refactoring.

This PR fix the current rendering order of the series, going back to the original order of theused in 7.4:

  • The series are listed top down on the editor, the legend and the tooltip (A,B,C)
  • each series are rendered bottom-up (C, B, A) where A is the top most series and should appear on top of all the other areas/bars.

This issue was already raised during the refactor PR #33558

[Logs] Response Codes Over Time + Annotations the order of the series is inverted, meaning that you have to reorder the way you are adding the series into the Chart component. It's reproducible when using stacked mode on a single visualization with a group by split

fix #52846

For reviewers
it's easier to see the changes when hiding the whitespaces from the diff -> Hide whitespace changes

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.6.0 labels Dec 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@markov00 markov00 requested review from alexwizp and sulemanof and removed request for alexwizp and sulemanof December 18, 2019 14:23
@markov00 markov00 requested a review from kertal December 18, 2019 14:32
@markov00
Copy link
Member Author

@elasticmachine merge upstream

}
)}
)
.reverse()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment here, why we should revert the array here.
This is not so obvious, and definitely in the future someone will try to remove it.

Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! TSVB part LGTM

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it seems, always the last edit wins in terms of rendering, shouldn't this graph stay purple if I edit the 2nd row which is orange:

71174602-e9eebd00-2265-11ea-80c1-67b29f05808e

@markov00
Copy link
Member Author

w which is orange:

Nice catch @kertal Let me check what we are missing

@markov00
Copy link
Member Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from elasticmachine Dec 27, 2019
@kibanamachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00 markov00 removed the v7.6.0 label Feb 4, 2020
@markov00
Copy link
Member Author

Closing and waiting for a fix in elastic-chart

@markov00 markov00 closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TSVB] color mismatch in 7.5.0
5 participants