Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Review jest match snapshot usage (all core and plugins included into snapshot) #58723

Closed
Dosant opened this issue Feb 27, 2020 · 1 comment · Fixed by #58724
Closed

[SIEM] Review jest match snapshot usage (all core and plugins included into snapshot) #58723

Dosant opened this issue Feb 27, 2020 · 1 comment · Fixed by #58724
Labels
Team:SIEM triage_needed

Comments

@Dosant
Copy link
Contributor

Dosant commented Feb 27, 2020 •
edited
Loading

Looks like test
https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/zeek/zeek_details.test.tsx#L116
does snapshot matching and the whole core and all plugins public contracts are included into the snapshot.
https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/zeek/__snapshots__/zeek_details.test.tsx.snap#L874

This causes ANY change to public api in core or plugin to break siem tests.

Introduced in: #57814
Similar to: #58165
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@angorayc angorayc mentioned this issue Feb 27, 2020
Merged
@Dosant Dosant linked a pull request Feb 27, 2020 that will close this issue
[SIEM] Clean up snapshot #58724
Merged
@lukeelmers lukeelmers mentioned this issue Feb 28, 2020
Merged
40 tasks
@lukasolson lukasolson mentioned this issue Feb 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:SIEM triage_needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SIEM] Clean up snapshot angorayc/kibana
2 participants
@Dosant @elasticmachine