Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Use settings from config rather than UI settings #58784

Merged
merged 7 commits into from
Feb 28, 2020
Merged

[Autocomplete] Use settings from config rather than UI settings #58784

merged 7 commits into from
Feb 28, 2020

Conversation

lukasolson
Copy link
Member

Summary

Fixes #58749.

Prior to this PR, since #53191, we were not correctly sending the terminate_after and timeout parameters in our requests to Elasticsearch for value suggestions. We were attempting to read them out of the UI (advanced) settings, rather than the config. This PR updates it to read them from the config instead.

Release note

KQL autocomplete requests for value suggestions are now correctly using the config values for kibana.autocompleteTimeout and kibana.autocompleteTerminateAfter for settings timeout and terminate_after in requests to Elasticsearch.

@lukasolson lukasolson requested review from alexwizp and a team February 27, 2020 22:19
@lukasolson lukasolson self-assigned this Feb 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukasolson lukasolson mentioned this pull request Feb 27, 2020
Merged
@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@lukasolson
Copy link
Member Author

Echoing #57064 (comment):

I believe this remaining failure was due to a massive snapshot in SIEM which needs to be removed. There's a PR open for removal (#58724); for the time being I've updated the snapshot.

@lukasolson lukasolson mentioned this pull request Feb 28, 2020
Merged
alexwizp
alexwizp approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All except zeek_details.test.tsx.snap LGTM. Tested locally

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukasolson lukasolson merged commit 8620f43 into elastic:master Feb 28, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58784 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 29, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58784 or prevent reminders by adding the backport:skip label.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 2, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ua/batch-rein…
17f39e7 
…dex-server-side

* 'master' of github.com:elastic/kibana: (34 commits)
  [Upgrade Assistant] Remove "boom" from reindex service (elastic#58715)
  [data] Clean up QueryStringInput unit tests (elastic#58704)
  [SIEM] Detection Fix typo in Adobe Hijack Persistence rule (elastic#58804)
  Restores [SIEM][CASE] Init Configure Case Page (elastic#58121) (elastic#58924)
  Skips additional failing Ingest Manager integration tests
  Skips failing Ingest Manager integration tests
  Move dev tools styles to NP (elastic#58855)
  change to have kibana --ssl cli option use more recent certs (elastic#57933)
  disable failing suite (elastic#58942)
  Don't start pollEsNodesVersion unless someone subscribes (elastic#56923)
  Do not write UUID file during optimize process (elastic#58899)
  [Endpoint] Task/add nav bar (elastic#58604)
  [Metric Alerts] Add backend support for multiple expressions per alert  (elastic#58672)
  [Metrics Alerts] Fix alerting on a rate aggregation (elastic#58789)
  disable flaky suite (elastic#55953)
  Revert "[SIEM] apollo@3 (elastic#51926)" and "[SIEM][CASE] Init Confi… (elastic#58806)
  [resubmit] Prep agg types for new platform (elastic#58893)
  [Lens] Allow number formatting within Lens (elastic#56253)
  [Autocomplete] Use settings from config rather than UI settings (elastic#58784)
  Improve action and trigger types (elastic#58657)
  ...

# Conflicts:
#	x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58784 or prevent reminders by adding the backport:skip label.

@lukasolson
Copy link
Member Author

7.6 (7.6.1): #58788
7.x (7.7.0): #58916

@lukasolson lukasolson added backported and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

@joshdover joshdover joshdover approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees

@lukasolson lukasolson

Labels
backported Feature:Filters Feature:KQL KQL release_note:fix v7.6.1 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Blocker] KQL Autocomplete chokes ES
6 participants
@lukasolson @elasticmachine @alexwizp @kibanamachine @mattkime @joshdover