[data] Clean up QueryStringInput unit tests #58704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
cla/check |
DianaDerevyankina
added
v8.0.0
v7.7.0
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
cla/check |
lizozom
reviewed
Feb 27, 2020
src/plugins/data/public/ui/query_string_input/query_bar_top_row.tsx
Outdated
Show resolved
Hide resolved
| @@ -584,4 +582,4 @@ export class QueryStringInputUI extends Component<Props, State> { | |||
| } | |||
| } | |||
|
|
|||
| export const QueryStringInput = injectI18n(withKibana(QueryStringInputUI)); | |||
| export const QueryStringInput = withKibana(QueryStringInputUI); | |||
There was a problem hiding this comment.
We can get rid of the variable and rename the class?
There was a problem hiding this comment.
QueryStringInput and QueryStringInputUI are both used in the other code pieces, so we can't get rid of any of them
There was a problem hiding this comment.
I think you could replace the existing usages, but its not critical
|
cla/check |
1 similar comment
|
cla/check |
DianaDerevyankina
force-pushed
the
58165
branch
from
d292cdd
to
fc36c1f
Compare
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 2, 2020
…dex-server-side * 'master' of github.com:elastic/kibana: (34 commits) [Upgrade Assistant] Remove "boom" from reindex service (elastic#58715) [data] Clean up QueryStringInput unit tests (elastic#58704) [SIEM] Detection Fix typo in Adobe Hijack Persistence rule (elastic#58804) Restores [SIEM][CASE] Init Configure Case Page (elastic#58121) (elastic#58924) Skips additional failing Ingest Manager integration tests Skips failing Ingest Manager integration tests Move dev tools styles to NP (elastic#58855) change to have kibana --ssl cli option use more recent certs (elastic#57933) disable failing suite (elastic#58942) Don't start pollEsNodesVersion unless someone subscribes (elastic#56923) Do not write UUID file during optimize process (elastic#58899) [Endpoint] Task/add nav bar (elastic#58604) [Metric Alerts] Add backend support for multiple expressions per alert (elastic#58672) [Metrics Alerts] Fix alerting on a rate aggregation (elastic#58789) disable flaky suite (elastic#55953) Revert "[SIEM] apollo@3 (elastic#51926)" and "[SIEM][CASE] Init Confi… (elastic#58806) [resubmit] Prep agg types for new platform (elastic#58893) [Lens] Allow number formatting within Lens (elastic#56253) [Autocomplete] Use settings from config rather than UI settings (elastic#58784) Improve action and trigger types (elastic#58657) ... # Conflicts: # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Mar 2, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
DianaDerevyankina
added a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #58165
Summary
Got rid of snapshot generation and refactored localization in components, so i18n is used now instead of InjectedIntl and injectI18n.
Checklist
Delete any items that are not applicable to this PR.
For maintainers