Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM][CASE] Init Configure Case Page #58121

Merged
merged 22 commits into from
Feb 28, 2020
Merged

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Feb 20, 2020

Summary

The PR implements the Configure Cases Page.

  • Adds Configure Cases button on the Cases page.
  • Enables links and redirects to Configure Cases Page.
  • Configuration Page: Connectors UI

configure_cases

Issues: #57864 , #50103

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 Team:SIEM labels Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas changed the title [SIEM][CASE] Configure Case Page [SIEM][CASE] Init Configure Case Page Feb 20, 2020
@cnasikas cnasikas added in progress WIP Work in progress labels Feb 23, 2020
@cnasikas cnasikas changed the title [SIEM][CASE] Init Configure Case Page [SIEM][CASE] [skip-ci] Init Configure Case Page Feb 23, 2020
@cnasikas cnasikas changed the title [SIEM][CASE] [skip-ci] Init Configure Case Page [SIEM][CASE] Init Configure Case Page Feb 26, 2020
@cnasikas cnasikas removed WIP Work in progress in progress labels Feb 26, 2020
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas cnasikas marked this pull request as ready for review February 26, 2020 16:53
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we are moving forward!!!

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hide that pesky timeline tab on the configure page. react-router-dom v5 has a useLocation hook that makes it very simple. import that function, and add/change the below lines in x-pack/legacy/plugins/siem/public/pages/home/index.tsx

... line 70

const location = useLocation();

... line 81

{indicesExistOrDataTemporarilyUnavailable(indicesExist) &&
  location.pathname !== `/${SiemPageName.case}/configure` && (
    <>
      <AutoSaveWarningMsg />
      <Flyout
        flyoutHeight={flyoutHeight}
        headerHeight={flyoutHeaderHeight}
        timelineId="timeline-1"
        usersViewing={usersViewing}
      >
        <StatefulTimeline
          flyoutHeaderHeight={flyoutHeaderHeight}
          flyoutHeight={flyoutHeight}
          id="timeline-1"
        />
      </Flyout>
    </>
  )}
... line 98

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🎸

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #29401 failed 70f0b67d3ea896a7ece28debc54d94df5cf5c57f
  • 💚 Build #29126 succeeded 18a4b648b8883f3a6b03304ccca0dc4304c3c4be
  • 💔 Build #29082 failed 0831dcb65a2676f0fa15e86ef2b945dea0a630a5
  • 💔 Build #28316 failed 15ada9eec49b7d9f82a1de1c2c342ef697a44da8
  • 💚 Build #28307 succeeded 7e72bf6a4425a2eccfa7398a8245f1bc4844f7dd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit 967bef7 into elastic:master Feb 28, 2020
@cnasikas cnasikas deleted the configure_cases branch February 28, 2020 11:59
cnasikas added a commit to cnasikas/kibana that referenced this pull request Feb 28, 2020
* [SIEM][CASE] Init configure cases

* [SIEM][CASE] Translate header title

* [SIEM][CASE] Add back link

* [SIEM][CASE] Add default options to header page

* [SIEM][CASE] Create configure cases page redirections and links

* [SIEM][CASE] Add configure cases button

* [SIEM][CASE] Change translation variable

* [SIEM][CASE] Create wrappers

* [SIEM][CASE]Create section wrapper

* [SIEM][CASE] Switch to new wrapper

* [SIEM][CASE] Add translations

* [SIEM][CASE] Add connectors dropdown component

* [SIEM][CASE] Add connectors component

* [SIEM][CASE] Show connectors

* [SIEM][CASE] Create add new connector button

* [SIEM][CASE] Change values

* [SIEM][CASE] Use state for connectors dropdown

* [SIEM][CASE] Remove unnecessary attribute

* [SIEM][CASE] Remove timeline in configuration page

* [SIEM][CASE] Remove text from gear button

* [SIEM][CASE] make show timeline more generic so we can re-use if need it

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cnasikas added a commit that referenced this pull request Feb 28, 2020
* [SIEM][CASE] Init configure cases

* [SIEM][CASE] Translate header title

* [SIEM][CASE] Add back link

* [SIEM][CASE] Add default options to header page

* [SIEM][CASE] Create configure cases page redirections and links

* [SIEM][CASE] Add configure cases button

* [SIEM][CASE] Change translation variable

* [SIEM][CASE] Create wrappers

* [SIEM][CASE]Create section wrapper

* [SIEM][CASE] Switch to new wrapper

* [SIEM][CASE] Add translations

* [SIEM][CASE] Add connectors dropdown component

* [SIEM][CASE] Add connectors component

* [SIEM][CASE] Show connectors

* [SIEM][CASE] Create add new connector button

* [SIEM][CASE] Change values

* [SIEM][CASE] Use state for connectors dropdown

* [SIEM][CASE] Remove unnecessary attribute

* [SIEM][CASE] Remove timeline in configuration page

* [SIEM][CASE] Remove text from gear button

* [SIEM][CASE] make show timeline more generic so we can re-use if need it

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger added a commit to spalger/kibana that referenced this pull request Feb 28, 2020
@cnasikas cnasikas restored the configure_cases branch February 28, 2020 17:17
spalger pushed a commit that referenced this pull request Feb 28, 2020
* Revert "[SIEM] apollo@3 (#51926)"

This reverts commit 320e292.

* Revert "[SIEM][CASE] Init Configure Case Page (#58121)"

This reverts commit 967bef7.

* update a snapshot...
cnasikas added a commit that referenced this pull request Mar 1, 2020
* [SIEM][CASE] Init configure cases

* [SIEM][CASE] Translate header title

* [SIEM][CASE] Add back link

* [SIEM][CASE] Add default options to header page

* [SIEM][CASE] Create configure cases page redirections and links

* [SIEM][CASE] Add configure cases button

* [SIEM][CASE] Change translation variable

* [SIEM][CASE] Create wrappers

* [SIEM][CASE] Create section wrapper

* [SIEM][CASE] Switch to new wrapper

* [SIEM][CASE] Add translations

* [SIEM][CASE] Add connectors dropdown component

* [SIEM][CASE] Add connectors component

* [SIEM][CASE] Show connectors

* [SIEM][CASE] Create add new connector button

* [SIEM][CASE] Change values

* [SIEM][CASE] Use state for connectors dropdown

* [SIEM][CASE] Remove unnecessary attribute

* [SIEM][CASE] Remove timeline in configuration page

* [SIEM][CASE] Remove text from gear button

* [SIEM][CASE] make show timeline more generic so we can re-use if need it

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 2, 2020
…dex-server-side

* 'master' of github.com:elastic/kibana: (34 commits)
  [Upgrade Assistant] Remove "boom" from reindex service (elastic#58715)
  [data] Clean up QueryStringInput unit tests (elastic#58704)
  [SIEM] Detection Fix typo in Adobe Hijack Persistence rule (elastic#58804)
  Restores [SIEM][CASE] Init Configure Case Page (elastic#58121) (elastic#58924)
  Skips additional failing Ingest Manager integration tests
  Skips failing Ingest Manager integration tests
  Move dev tools styles to NP (elastic#58855)
  change to have kibana --ssl cli option use more recent certs (elastic#57933)
  disable failing suite (elastic#58942)
  Don't start pollEsNodesVersion unless someone subscribes (elastic#56923)
  Do not write UUID file during optimize process (elastic#58899)
  [Endpoint] Task/add nav bar (elastic#58604)
  [Metric Alerts] Add backend support for multiple expressions per alert  (elastic#58672)
  [Metrics Alerts] Fix alerting on a rate aggregation (elastic#58789)
  disable flaky suite (elastic#55953)
  Revert "[SIEM] apollo@3 (elastic#51926)" and "[SIEM][CASE] Init Confi… (elastic#58806)
  [resubmit] Prep agg types for new platform (elastic#58893)
  [Lens] Allow number formatting within Lens (elastic#56253)
  [Autocomplete] Use settings from config rather than UI settings (elastic#58784)
  Improve action and trigger types (elastic#58657)
  ...

# Conflicts:
#	x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants