Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor saved object types to use namespaceType instead of namespaceAgnostic #60981

Closed
jportner opened this issue Mar 23, 2020 · 1 comment · Fixed by #63217
Closed

Refactor saved object types to use namespaceType instead of namespaceAgnostic #60981

jportner opened this issue Mar 23, 2020 · 1 comment · Fixed by #63217
Assignees
@jportner
Labels
chore Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jportner
Copy link
Contributor

jportner commented Mar 23, 2020 •
edited
Loading

This is a follow-on to #54043.

As discussed in #54605 (comment), the SavedObjectsType currently has a boolean attribute named namespaceAgnostic. With Sharing Saved Objects, we now have three mutually-exclusive "namespace types" (namespace-agnostic, single-namespace, and multi-namespace) -- accordingly, that boolean attribute doesn't make sense anymore.

That PR deprecated the namespaceAgnostic attribute and added a new one, namespaceType. Now we need to replace deprecated usages and remove that attribute completely.
@jportner jportner added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Mar 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jportner jportner mentioned this issue Apr 1, 2020
Merged
@jportner jportner mentioned this issue Apr 10, 2020
Merged
@jportner jportner added the Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jportner jportner

Labels
chore Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor saved object types to use namespaceType jportner/kibana
2 participants
@jportner @elasticmachine