Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor saved object types to use namespaceType #63217

Merged
merged 6 commits into from
Apr 16, 2020
Merged

Refactor saved object types to use namespaceType #63217

merged 6 commits into from
Apr 16, 2020

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Apr 10, 2020 •
edited
Loading

Remove namespaceAgnostic field that was deprecated in #54605, use namespaceType instead.

Resolves #60981.

@jportner
Refactor saved object types to use namespaceType
9d1e8b1 
Remove `namespaceAgnostic` field that was deprecated in elastic#54605,
use `namespaceType` instead.
@jportner jportner added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 chore labels Apr 10, 2020
jportner
jportner commented Apr 10, 2020
View reviewed changes
src/core/server/saved_objects/types.ts
Comment on lines -213 to +208
namespaceType?: SavedObjectsNamespaceType;
namespaceType: SavedObjectsNamespaceType;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before #54605 was merged, the namespaceAgnostic field was required. Now that we are removing it, the namespaceType field should be required.

@jportner jportner marked this pull request as ready for review April 10, 2020 16:56
@jportner jportner requested review from a team as code owners April 10, 2020 16:56
@pgayvallet
Copy link
Contributor

ack: will review today

pgayvallet
pgayvallet reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM for platform changes. Thanks for the quick follow-up.

src/core/server/saved_objects/saved_objects_type_registry.ts Show resolved Hide resolved
pgayvallet
pgayvallet approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval is better than comment 😄

@lizozom
Copy link
Contributor

lizozom commented Apr 14, 2020

@elasticmachine merge upstream

lizozom
lizozom approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppArch changes LGTM

legrego
legrego approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

afharo
afharo approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulse changes LGTM!

@jportner jportner requested a review from a team April 16, 2020 14:19
stephmilovic
stephmilovic approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the changes to x-pack/plugins/case

jgowdyelastic
jgowdyelastic approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

timroes
timroes approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Kibana App code only, code LGTM, haven't tested

@jportner jportner merged commit d72de0e into elastic:master Apr 16, 2020
@jportner jportner deleted the issue-60981-remove-namspace-agnostic branch April 16, 2020 18:37
@jportner jportner added backport pending and removed Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Apr 16, 2020
@jportner jportner mentioned this pull request Apr 16, 2020
Merged
jportner added a commit that referenced this pull request Apr 16, 2020
@jportner
[7.x] Refactor SO types to use namespaceType (#63217) (#63745)
f6cb14a 
Remove `namespaceAgnostic` field that was deprecated in #54605,
use `namespaceType` instead.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 17, 2020
@gmmorris
Merge branch 'master' into alerting/es-query
34e0612 
* master: (40 commits)
  [APM]Upgrade apm-rum agent to latest version to fix full page reload (elastic#63723)
  add deprecation warning for legacy 3rd party plugins (elastic#62401)
  Migrate timelion vis (elastic#62819)
  Replacebad scope link with actual values (elastic#63444)
  Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) (elastic#63111)
  [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends (elastic#61207)
  [Maps] fix term join agg key collision (elastic#63324)
  [Ingest] Fix agent config key sorting (elastic#63488)
  [Monitoring] Fixed server response errors (elastic#63181)
  update elastic charts to 18.3.0 (elastic#63732)
  Start services (elastic#63720)
  [APM] Encode spaces when creating ML job (elastic#63683)
  Uptime 7.7 docs (elastic#62228)
  [DOCS] Updates remote cluster and ccr docs (elastic#63517)
  [Maps] Add 3rd party vector tile support (elastic#62084)
  [Endpoint][EPM] Retrieve Index Pattern from Ingest Manager (elastic#63016)
  [Endpoint] Host Details Policy Response Panel (elastic#63518)
  [Uptime] Certificate expiration threshold settings (elastic#63682)
  Refactor saved object types to use `namespaceType` (elastic#63217)
  [SIEM][CASE] Create comments sequentially (elastic#63692)
  ...
@cee-chen cee-chen mentioned this pull request Jun 2, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@afharo afharo afharo approved these changes

@legrego legrego legrego approved these changes

@lizozom lizozom lizozom approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor saved object types to use namespaceType instead of namespaceAgnostic
10 participants
@jportner @pgayvallet @lizozom @elasticmachine @kibanamachine @timroes @legrego @afharo @stephmilovic @jgowdyelastic