-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-configured connectors not easy to configure in kibana.yml #63171
Comments
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Here's what I'm using, which works as far as I can tell:
I'm not opposed to the form you're suggesting though, which presumably means the keys will be the action ids, though we will have do some filtering to prevent prototype pollution on them (probably?). |
@pmuellr oh, I was thinking only JSON objects could be passed through. Didn't know what you have is what is needed to make arrays work. I will close this issue, thanks for the insight! |
Re-opening this, as we found that the structure for these doesn't work great when you want to configure the keys in the kibana keystore; you have to reference the secrets with the index they are in the array, like so:
(note, customers would use Going to look to see how changing the structure so it's an object with action ids as they keys works out. That should allow you to do something like the following, where
|
resolves elastic#63171 Previously, preconfigured actions were specified as an array of action properties. This ended up being problematic when using the kibana keystore for secrets, as you'd have to reference specific actions via index. This changes preconfigured actions to be specified as an object, where the property key is the id, and the body is the remainder of the action properties. As access to preconfigured actions has leaked across the code base, it's probably time to consider changing the internal representation from an array to a Map, to provide easier access by action id. For a future PR.
…65397) resolves #63171 Previously, preconfigured actions were specified as an array of action properties. This ended up being problematic when using the kibana keystore for secrets, as you'd have to reference specific actions via index. This changes preconfigured actions to be specified as an object, where the property key is the id, and the body is the remainder of the action properties. As access to preconfigured actions has leaked across the code base, it's probably time to consider changing the internal representation from an array to a Map, to provide easier access by action id. For a future PR.
…lastic#65397) resolves elastic#63171 Previously, preconfigured actions were specified as an array of action properties. This ended up being problematic when using the kibana keystore for secrets, as you'd have to reference specific actions via index. This changes preconfigured actions to be specified as an object, where the property key is the id, and the body is the remainder of the action properties. As access to preconfigured actions has leaked across the code base, it's probably time to consider changing the internal representation from an array to a Map, to provide easier access by action id. For a future PR.
…lastic#65397) resolves elastic#63171 Previously, preconfigured actions were specified as an array of action properties. This ended up being problematic when using the kibana keystore for secrets, as you'd have to reference specific actions via index. This changes preconfigured actions to be specified as an object, where the property key is the id, and the body is the remainder of the action properties. As access to preconfigured actions has leaked across the code base, it's probably time to consider changing the internal representation from an array to a Map, to provide easier access by action id. For a future PR. # Conflicts: # docs/user/alerting/action-types/email.asciidoc # docs/user/alerting/action-types/index.asciidoc # docs/user/alerting/action-types/pagerduty.asciidoc # docs/user/alerting/action-types/server-log.asciidoc # docs/user/alerting/action-types/slack.asciidoc # docs/user/alerting/action-types/webhook.asciidoc # docs/user/alerting/pre-configured-connectors.asciidoc
…65397) (#65756) resolves #63171 Previously, preconfigured actions were specified as an array of action properties. This ended up being problematic when using the kibana keystore for secrets, as you'd have to reference specific actions via index. This changes preconfigured actions to be specified as an object, where the property key is the id, and the body is the remainder of the action properties. As access to preconfigured actions has leaked across the code base, it's probably time to consider changing the internal representation from an array to a Map, to provide easier access by action id. For a future PR.
…65397) (#65759) resolves #63171 Previously, preconfigured actions were specified as an array of action properties. This ended up being problematic when using the kibana keystore for secrets, as you'd have to reference specific actions via index. This changes preconfigured actions to be specified as an object, where the property key is the id, and the body is the remainder of the action properties. As access to preconfigured actions has leaked across the code base, it's probably time to consider changing the internal representation from an array to a Map, to provide easier access by action id. For a future PR. # Conflicts: # docs/user/alerting/action-types/email.asciidoc # docs/user/alerting/action-types/index.asciidoc # docs/user/alerting/action-types/pagerduty.asciidoc # docs/user/alerting/action-types/server-log.asciidoc # docs/user/alerting/action-types/slack.asciidoc # docs/user/alerting/action-types/webhook.asciidoc # docs/user/alerting/pre-configured-connectors.asciidoc
The
xpack.actions.preconfigured
kibana.yml configuration currently accepts an array of objects but doesn't make it easy to configure in YML. Using for example a collection, it would be more natural to configure like the following example:The text was updated successfully, but these errors were encountered: