Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome UI Functional Tests.test/functional/apps/saved_objects_management/edit_saved_object·ts - saved objects management saved objects edition page allows to delete a saved object #68400

Closed
kibanamachine opened this issue Jun 5, 2020 · 36 comments · Fixed by #91809, #97846 or #115291
Closed

Failing test: Chrome UI Functional Tests.test/functional/apps/saved_objects_management/edit_saved_object·ts - saved objects management saved objects edition page allows to delete a saved object #68400

kibanamachine opened this issue Jun 5, 2020 · 36 comments · Fixed by #91809, #97846 or #115291
Assignees
@afharo
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 5, 2020 •
edited
Loading

A test failed on a tracked branch

{ TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="savedObjectsTable"])
Wait timed out after 10063ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jun 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@brianseeders brianseeders added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@rudolf
Copy link
Contributor

rudolf commented Jul 9, 2020

Don't have a lot of experience with our FTR but I think this could be a race condition:

We wait for the table to complete loading:

kibana/test/functional/page_objects/management/saved_objects_page.ts

Lines 89 to 97 in 6ebf56b

return retry.try(async () => {
const exists = await find.existsByDisplayedByCssSelector(
'*[data-test-subj="savedObjectsTable"] .euiBasicTable-loading'
);
if (exists) {
throw new Error('Waiting');
}
return true;
});

But if the test is fast enough, the table might not be present on the page at all so the waiting test passes. Instead we should first wait until *[data-test-subj="savedObjectsTable"] is present, and then wait until it no longer has the .euiBasicTable-loading class applied.

@rudolf rudolf mentioned this issue Jul 9, 2020
Merged
7 tasks
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

mistic added a commit that referenced this issue Jul 13, 2020
@mistic
skip flaky suite (#68400)
e082719
mistic added a commit that referenced this issue Jul 13, 2020
@mistic
skip flaky suite (#68400)
3991524
mistic added a commit that referenced this issue Jul 13, 2020
@mistic
skip flaky suite (#68400)
df7e2ed
@mistic
Copy link
Member

mistic commented Jul 13, 2020

That has been flaky and I've skipped it for master, 7.x and 7.8.

Screenshot 2020-07-13 at 17 08 50

@afharo
Copy link
Member

afharo commented Feb 16, 2021

We're planning to remove this feature in 8.0. Timebox the effort

@Bamieh Bamieh mentioned this issue Feb 18, 2021
Merged
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine kibanamachine reopened this Feb 18, 2021
@jbudz
Copy link
Member

jbudz commented Feb 19, 2021 •
edited
Loading

I reverted #91809 due to ^ and https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/2302/

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@afharo afharo mentioned this issue Apr 21, 2021
Closed
@afharo afharo mentioned this issue Apr 21, 2021
Merged
9 tasks
@afharo afharo assigned afharo and unassigned Bamieh Apr 21, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build

@kibanamachine kibanamachine reopened this Sep 21, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.x

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.x

spalger added a commit that referenced this issue Oct 13, 2021
@spalger
skip flaky suite (#68400)
38f949a
spalger added a commit that referenced this issue Oct 13, 2021
@spalger
skip flaky suite (#68400)
0bcc108
@spalger
Copy link
Contributor

spalger commented Oct 13, 2021

Skipped again

master/8.0: 38f949a
7.x/7.16: 0bcc108

jloleysens added a commit to jloleysens/kibana that referenced this issue Oct 13, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reportingg/gu…
32c6f05 
…ide-users-to-saving-ux

* 'master' of github.com:elastic/kibana: (133 commits)
  [DOCS] Indicate reports are a subscription feature (elastic#114653)
  Update namespace for indices (elastic#114612)
  [DOCS] Adds Logstash pipeline settings (elastic#114648)
  Bump EPR snapshot version used for tests (elastic#114529)
  [Security Solution] [Endpoint] Fleet summary card adjustments (elastic#114291)
  skip flaky suite (elastic#68400)
  [Visualizations] fix usage of optional dependencies (elastic#114286)
  [Security Solution] [Detections] Improves custom query rule upgrade test (elastic#114454)
  [fleet] Add Integration Preference selector (elastic#114432)
  [Reporting] Add new `data-render-error` attribute (elastic#114472)
  Replace EuiCodeEditor with CodeEditor in app-services code (elastic#114316)
  [data views] add getDefaultDataView method  (elastic#113891)
  [Security Solution] [Endpoint] Event filters uses the new card design (elastic#114126)
  [fleet] Tweak Header UI (elastic#114704)
  [APM] Filter on tx metrics for instance stats (elastic#114758)
  [APM] Fix typo in linting docs (elastic#114764)
  [Discover] Removing SavedObject usage for savedSearch (elastic#112983)
  [Fleet] Add Integration Policy Page Improvements (elastic#114556)
  [Lens] Keep the custom label when transitioning to/from Formula (elastic#114270)
  [Security Solution][Endpoint] Host Isolation API changes (elastic#113621)
  ...
@TinaHeiligers TinaHeiligers mentioned this issue Oct 16, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone