Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Assistant should work with token based authentication #72014

Closed
jloleysens opened this issue Jul 16, 2020 · 5 comments
Closed

Upgrade Assistant should work with token based authentication #72014

jloleysens opened this issue Jul 16, 2020 · 5 comments
Assignees
Labels
blocked enhancement New value added to drive a business result Feature:Security/Authentication Platform Security - Authentication Feature:Upgrade Assistant impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jloleysens
Copy link
Contributor

Upon receiving a request to reindex, Upgrade Assistant (UA) stores the requester's credentials in memory and uses those credentials when updating saved objects and issuing requests for other reindexing related operations.

In a token-based authentication mechanism these tokens have an expiration time that could expire before reindexing work completes causing the task to stall. With state of reindexing tracked inside of saved objects this should be recoverable but the ideal would be that no recovery is required.

At the moment there is no simple way to refresh the auth token on behalf of the requester.

See https://github.com/elastic/kibana-team/issues/1331 for a similar issue and a proposed solution.

@jloleysens jloleysens added blocked Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Authentication Platform Security - Authentication Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal cjcenizal added the enhancement New value added to drive a business result label Jul 21, 2020
@legrego
Copy link
Member

legrego commented Aug 3, 2021

This will become more of an issue now that ESS configures SAML as the default authentication experience for deployment administrators.

I don't know the specifics of the upgrade assistant, but I wonder if our solution to #104893 could improve the situation here (cc @azasypkin)

@azasypkin
Copy link
Member

I don't know the specifics of the upgrade assistant, but I wonder if our solution to #104893 could improve the situation here (cc @azasypkin)

If the UA implementation hasn't changed since #72014 (comment) then the solution for #104893 probably won't help since we won't have access to the refresh token. Probably relying on the temporary API key (in case API keys are enabled) would be the best option.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 5, 2021
@alisonelizabeth alisonelizabeth self-assigned this Sep 7, 2021
@alisonelizabeth
Copy link
Contributor

Addressed via #111451.

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New value added to drive a business result Feature:Security/Authentication Platform Security - Authentication Feature:Upgrade Assistant impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

6 participants