Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strike through line is missing on disabled pinned filter. #72695

Closed
bhavyarm opened this issue Jul 21, 2020 · 1 comment · Fixed by #79641
Closed

Strike through line is missing on disabled pinned filter. #72695

bhavyarm opened this issue Jul 21, 2020 · 1 comment · Fixed by #79641
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 7.9.0 BC2

Elasticsearch version: 7.9.0 BC2

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If there is a warning on filter pill because "pinned field does not exist in the current view" - disabling it works fine but there is no strike throug line which makes the visuals clear that filter is disabled.

Steps to reproduce:

  1. Go to discover, pick your favourite sample data and add a filter and pin it
  2. Go to dashboards and open other dashboards (not built on data from step 1)
  3. The pinned filter gets displayed with a warning.
  4. You don't want to deal with it - so click on disabling it
  5. The dashboard is up with correct data but strike throug line is missing on the pinned filter

Expected behavior:
There should be a strike through so its clear to the user - they disabled it (it will also be consistent with how other pinned filters will behave without warning)

Screenshots (if relevant):

Pinned filter with disabled strike trhough:
Screen Shot 2020-07-21 at 12 45 30 PM

Pinned filter with warning and disabled but no strike through:
Screen Shot 2020-07-21 at 12 45 02 PM

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Filters Team:AppArch labels Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters
Projects
None yet
3 participants