Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][Filters] Add strike-through line for disabled filters in warning and error state #79641

Merged
merged 3 commits into from
Oct 7, 2020
Merged

[Bugfix][Filters] Add strike-through line for disabled filters in warning and error state #79641

merged 3 commits into from
Oct 7, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 6, 2020 •
edited
Loading

Summary

Fixes #72695

  1. There is an error state. In this state filter is not applicable and is disabled. Such filter can't be reenabled.
  2. Then there is a "warning" state filters. Such filters can be applied (not entirely disabled) and this state points users to possible issue with a filter. One of the cases is when filter is using index pattern which is not on a dashboard.

This issue points out #72695 that in disabled state such filters weren't not crossed-out

Before:

Screenshot 2020-10-06 at 13 54 17

Screenshot 2020-10-06 at 13 56 35

After:

Screenshot 2020-10-07 at 12 13 02
Screenshot 2020-10-06 at 13 56 39

Warning filters can be reenabled:

Screenshot 2020-10-06 at 13 57 53

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Filters v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 6, 2020
@Dosant Dosant marked this pull request as ready for review October 6, 2020 13:43
@Dosant Dosant requested a review from a team as a code owner October 6, 2020 13:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant requested review from lizozom and cchaos October 6, 2020 13:43
@Dosant Dosant changed the title [Bugfix][Filters] Add strike-through line for disabled filter in warning state [Bugfix][Filters] Add strike-through line for disabled filters in warning and error state Oct 7, 2020
@Dosant Dosant requested a review from cchaos October 7, 2020 10:17
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
data 1.1MB 1.1MB -360.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cchaos
cchaos approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks screenshots and code LGTM, didn't test locally.

@Dosant Dosant merged commit 82a6ddb into elastic:master Oct 7, 2020
@Dosant Dosant mentioned this pull request Oct 8, 2020
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Oct 8, 2020
@Dosant
[Bugfix][Filters] Add strike-through line for disabled filters in war…
ba3f4b7 
…ning and error state (elastic#79641)

Adds the strikethrough for all disabled filter pills no matter the error/warning states
Dosant added a commit that referenced this pull request Oct 8, 2020
@Dosant
[Bugfix][Filters] Add strike-through line for disabled filters in war…
d0049d2 
…ning and error state (#79641) (#79973)

Adds the strikethrough for all disabled filter pills no matter the error/warning states
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@lizozom lizozom Awaiting requested review from lizozom

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strike through line is missing on disabled pinned filter.
4 participants
@Dosant @elasticmachine @kibanamachine @cchaos