-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Many environments are not displayed in dropdown filter #77695
Comments
Pinging @elastic/apm-ui (Team:apm) |
Just noticed it stops at 10 (including Not defined), the default size for aggregations, so this is likely the cause. |
It looks like fixing the query would be important here. @ogupte - would it make sense to redesign the environment selector and make it a dropdown with a typeahead for better usability? |
I don't think we've seen customers with 100s of environments (they are often less than 10), so I'm not sure if this is a scenario we should invest in improving. For the time being, instead of registering a separate environment per dev, could they set a separate service name? I know it seems like a hack but would probably work better. |
@sqren don't think adding support for spaces would exactly solve the issue and creating service names with environments is pretty hacky(also won't work for things like maps where you want to view maps of specific environments only). Lets make the query configurable for now to unblock folks and consider re-designing the filter as per @alex-fedotyev suggestion? |
Adds new configuration 'xpack.apm.ui.maxServiceEnvironments' to set the max number of service environments visible in APM UI.
* Closes #77695. Adds new configuration 'xpack.apm.ui.maxServiceEnvironments' to set the max number of service environments visible in APM UI. * renamed config 'xpack.apm.ui.maxServiceEnvironments' -> 'xpack.apm.maxServiceEnvironments' * Renames 'xpack.apm.ui.maxServiceEnvironments' -> 'xpack.apm.maxServiceEnvironments' in the docs. * removed incorrect size param on the composite terms sub-agg Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…tic#82090) * Closes elastic#77695. Adds new configuration 'xpack.apm.ui.maxServiceEnvironments' to set the max number of service environments visible in APM UI. * renamed config 'xpack.apm.ui.maxServiceEnvironments' -> 'xpack.apm.maxServiceEnvironments' * Renames 'xpack.apm.ui.maxServiceEnvironments' -> 'xpack.apm.maxServiceEnvironments' in the docs. * removed incorrect size param on the composite terms sub-agg Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…) (#82903) * Closes #77695. Adds new configuration 'xpack.apm.ui.maxServiceEnvironments' to set the max number of service environments visible in APM UI. * renamed config 'xpack.apm.ui.maxServiceEnvironments' -> 'xpack.apm.maxServiceEnvironments' * Renames 'xpack.apm.ui.maxServiceEnvironments' -> 'xpack.apm.maxServiceEnvironments' in the docs. * removed incorrect size param on the composite terms sub-agg Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
When exploring an instance with a lot of environments, not all environments will display in the environment filter. This might be because we query for environments using a
terms
agg with asize
specified (https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/server/lib/ui_filters/get_environments.ts#L56-L59). The solution might be more involved than specifying a large enoughsize
because a large size would greatly impact performance. Another solution would be to use acomposite
aggregration to get the distinct environment values. This would introduce pagination to this query which might need changes to the UI selector to trigger loading new page of environments.Related: #77573
The text was updated successfully, but these errors were encountered: