Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Tile Server Config at Visualization Level #7784

Closed
jeffreyeliotabbott opened this issue Jul 20, 2016 · 7 comments
Closed

Expose Tile Server Config at Visualization Level #7784

jeffreyeliotabbott opened this issue Jul 20, 2016 · 7 comments
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement

Comments

@jeffreyeliotabbott
Copy link

When creating or editing visualizations, authors should have the option for an alternate tile server, as is currently available for a WMS server. This would allow users to select the most appropriate tile server for their content and what they are trying to encode visually.

@tbragin
Copy link
Contributor

tbragin commented Jul 20, 2016

@epixa @spalger Configurability of the tile server at the vis level may be really useful (in addition to the global config we have in kibana.yml), so users can configure different style tiles for different maps. You can imagine one dashboard being more focused on terrain and another more on streets, served up by the same kibana instance. Not to mention, this will match WMS server configurability which currently lives on the vis level.

@jbudz
Copy link
Member

jbudz commented Jul 21, 2016

I'm +1 on adding more map servers, but I think we need to be careful about it. Tile map requests are sent out automatically to potential external services when entering visualize or dashboards, and until advanced settings and saved objects aren't locked down I don't think it should be allowed. I realize this isn't the case now, and I think it would be good to move all external services to kibana.yml.

This would look something like adding a collection of approved tilemap, wms servers to kibana.yml and selecting them from a list when building a map. This would let us layer maps too, if we want a weather layer on top of a world map for example.

@tbragin
Copy link
Contributor

tbragin commented Jul 21, 2016

@jbudz good point. whatever we decide, seems like we might consider aligning how we handle it for WMS vs Tile servers.

@spalger
Copy link
Contributor

spalger commented Jul 21, 2016

I really like the idea of defining a set of configurations in the kibana.yml file that are presented to the user, it also means that only the admin needs to know the underlying protocol each tile service uses (wms, png tiles, etc)

@tbragin tbragin added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Coordinate Map labels Oct 31, 2016
@tbragin
Copy link
Contributor

tbragin commented Nov 9, 2016

From discussion with @spalger, @epixa, @jbudz and others on the team:

  • Consistency is indeed important
  • We are not fundamentally opposed to having tile map server config at the visualization level, like we have WMS configuration
  • However, the visualization level configuration should be an over-ride and the global default should still live in kibana.yml

@alexfrancoeur alexfrancoeur added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Feb 6, 2018
@timroes timroes removed the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Apr 11, 2018
@thomasneirynck
Copy link
Contributor

We are working on a new implementation of map visualizations and are not planning to add any new features to the existing implementation. We will take this suggestion under consideration for the new app.

@nreese
Copy link
Contributor

nreese commented Feb 28, 2019

This feature request has been implemented in the new Maps application. The Maps application will be available as a beta preview in the upcoming stack releases 6.7.0 and 7.0.0.

You can try the new Maps application today with the 7.0.0-beta1 release

@nreese nreese closed this as completed Feb 28, 2019
tkajtoch added a commit that referenced this issue May 29, 2024
`v94.5.1` ⏩ `v94.5.2`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v94.5.2`](https://github.com/elastic/eui/releases/v94.5.2)

**Bug fixes**

- Fixed `EuiDatePicker` to more gracefully handle incorrectly formatted
`selected` Moment dates, instead of simply crashing
([#7784](elastic/eui#7784))
- Fixed `EuiFlexGroup` and `EuiFlexItem` types to correctly accept
global attribute props and simplify type resolution when used with
`styled()`-like wrappers
([#7792](elastic/eui#7792))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement
Projects
None yet
Development

No branches or pull requests

8 participants