Private mode in Safari causes console error: "QuotaExceededError: DOM Exception 22"

[cjcenizal]

Kibana version: 4.6.0

Elasticsearch version: 2.4.0

Server OS version: OS X

Browser version: Safari (private browsing mode)

Browser OS version: OS X

Steps to reproduce:

1. Open up Safari in private browsing mode, and open Kibana.
2. Kibana won't load and the console will show an error: QuotaExceededError: DOM Exception 22

The problem

It looks like this problem is related to Safari disallowing access to localStorage when in private browsing mode: http://stackoverflow.com/questions/14555347/html5-localstorage-error-with-safari-quota-exceeded-err-dom-exception-22-an

It looks like nav.js is the culprit, in these two places:

• https://github.com/elastic/kibana/blob/4.x/src/ui/public/chrome/api/nav.js#L41
• https://github.com/elastic/kibana/blob/4.x/src/ui/public/chrome/api/nav.js#L10

In both places, calls are being made to appUrlStore, using its getItem and setItem methods. It looks like appUrlStore is an alias for window.sessionStorage: https://github.com/elastic/kibana/blob/4.x/src/ui/public/chrome/api/apps.js#L10

Possible solution

We can probably fix this by wrapping the setItem and getItem calls in a try/catch block, and display an error to the user in the catch:

try {
  internals.appUrlStore.setItem(`lastSubUrl:${link.url}`, url);
} catch(error) {
  // Imperatively write some markup to the DOM to show an error notification stating: "Sorry, Kibana requires access to sessionStorage, and it looks like your browser isn't providing access to sessionStorage. If you're using Safari with private browsing enabled, you can solve this problem by disabling private browsing, or by using another browser."
}

[epixa]

It looks like this issue would exist in 4.5.4 as well.

[spalger]

Closed by #8063

[epixa]

@spalger You closed it with its own issue number rather than linking to a PR

[epixa]

Closed by #8343

[spalger]

lol