Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy is broken for ES due to custom headers PR #8093

Closed
epixa opened this issue Aug 25, 2016 · 5 comments
Closed

Proxy is broken for ES due to custom headers PR #8093

epixa opened this issue Aug 25, 2016 · 5 comments
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience v4.6.0

Comments

@epixa
Copy link
Contributor

epixa commented Aug 25, 2016

This is just a placeholder. I'll flesh this out with more details soon.

#8032 broke some stuff when kibana doesn't have ssl and elasticsearch does.

@epixa epixa added bug Fixes for quality problems that affect the customer experience blocker v4.6.0 labels Aug 25, 2016
@epixa epixa self-assigned this Aug 25, 2016
@alexbrasetvik
Copy link
Contributor

It breaks with plain http too, seems something is rewriting http://hostname with http://1.2.3.4

@alexbrasetvik
Copy link
Contributor

What has happened to preserveHost?

On a89947e:

$ git grep -i preserveH
config/kibana.yml:# elasticsearch.preserveHost: true
docs/settings.asciidoc:`elasticsearch.preserveHost` added[4.2]:: By default, the host specified in the incoming request from the browser is specified as the host in the corresponding request Kibana sends to Elasticsearch. If you set this option to `false`, Kibana uses the host specified in `elasticsearch_url`.
src/cli/serve/read_yaml_config.js:  elasticsearch_preserve_host: 'elasticsearch.preserveHost',
src/plugins/elasticsearch/index.js:        preserveHost: boolean().default(true),

It's set and documented but never used?

@epixa
Copy link
Contributor Author

epixa commented Aug 26, 2016

It looks like preserveHost has been broken for a year with absolutely no noise (ie. bug reports), so I'm just going to remove it entirely in 5.0.

@epixa
Copy link
Contributor Author

epixa commented Aug 26, 2016

This shouldn't be an issue in 5.0 because the host header won't be proxied by default anyway.

@w33ble
Copy link
Contributor

w33ble commented Aug 26, 2016

Closed by #8105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience v4.6.0
Projects
None yet
Development

No branches or pull requests

3 participants