Respect configured elasticsearch host in proxy #8105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy should not send along the host header from the client and instead should pass a host header derived from the configured elasticsearch url, otherwise Kibana cannot run on a different host than elasticsearch.
|
/cc @hub-cap |
|
LGTM |
|
LGTM! |
jbudz
pushed a commit
that referenced
this pull request
Nov 12, 2024
`v97.3.0`⏩`v97.3.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1) **Bug fixes** - Fixed an `EuiComboBox` bug where Enter keypresses were not working correctly on selection clear buttons ([#8105](elastic/eui#8105)) - Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of smaller widths instead of truncating ([#8109](elastic/eui#8109)) - Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness where single items could overflow past the intended max width ([#8110](elastic/eui#8110))
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
`v97.3.0`⏩`v97.3.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1) **Bug fixes** - Fixed an `EuiComboBox` bug where Enter keypresses were not working correctly on selection clear buttons ([elastic#8105](elastic/eui#8105)) - Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of smaller widths instead of truncating ([elastic#8109](elastic/eui#8109)) - Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness where single items could overflow past the intended max width ([elastic#8110](elastic/eui#8110))
cee-chen
added a commit
to cee-chen/kibana
that referenced
this pull request
Nov 13, 2024
`v97.3.0`⏩`v97.3.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1) **Bug fixes** - Fixed an `EuiComboBox` bug where Enter keypresses were not working correctly on selection clear buttons ([elastic#8105](elastic/eui#8105)) - Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of smaller widths instead of truncating ([elastic#8109](elastic/eui#8109)) - Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness where single items could overflow past the intended max width ([elastic#8110](elastic/eui#8110)) (cherry picked from commit 4e65ae9) # Conflicts: # packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap
cee-chen
added a commit
that referenced
this pull request
Nov 13, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Upgrade EUI to v97.3.1 (#199186)](#199186) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-12T01:02:34Z","message":"Upgrade EUI to v97.3.1 (#199186)\n\n`v97.3.0`⏩`v97.3.1`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)\r\n\r\n**Bug fixes**\r\n\r\n- Fixed an `EuiComboBox` bug where Enter keypresses were not working\r\ncorrectly on selection clear buttons\r\n([#8105](https://github.com/elastic/eui/pull/8105))\r\n- Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of\r\nsmaller widths instead of truncating\r\n([#8109](https://github.com/elastic/eui/pull/8109))\r\n- Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness\r\nwhere single items could overflow past the intended max width\r\n([#8110](https://github.com/elastic/eui/pull/8110))","sha":"4e65ae9b1e69fc92341de99078bde179708b3394","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","backport:version","v8.17.0"],"number":199186,"url":"https://github.com/elastic/kibana/pull/199186","mergeCommit":{"message":"Upgrade EUI to v97.3.1 (#199186)\n\n`v97.3.0`⏩`v97.3.1`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)\r\n\r\n**Bug fixes**\r\n\r\n- Fixed an `EuiComboBox` bug where Enter keypresses were not working\r\ncorrectly on selection clear buttons\r\n([#8105](https://github.com/elastic/eui/pull/8105))\r\n- Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of\r\nsmaller widths instead of truncating\r\n([#8109](https://github.com/elastic/eui/pull/8109))\r\n- Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness\r\nwhere single items could overflow past the intended max width\r\n([#8110](https://github.com/elastic/eui/pull/8110))","sha":"4e65ae9b1e69fc92341de99078bde179708b3394"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199186","number":199186,"mergeCommit":{"message":"Upgrade EUI to v97.3.1 (#199186)\n\n`v97.3.0`⏩`v97.3.1`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1)\r\n\r\n**Bug fixes**\r\n\r\n- Fixed an `EuiComboBox` bug where Enter keypresses were not working\r\ncorrectly on selection clear buttons\r\n([#8105](https://github.com/elastic/eui/pull/8105))\r\n- Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of\r\nsmaller widths instead of truncating\r\n([#8109](https://github.com/elastic/eui/pull/8109))\r\n- Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness\r\nwhere single items could overflow past the intended max width\r\n([#8110](https://github.com/elastic/eui/pull/8110))","sha":"4e65ae9b1e69fc92341de99078bde179708b3394"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
`v97.3.0`⏩`v97.3.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1) **Bug fixes** - Fixed an `EuiComboBox` bug where Enter keypresses were not working correctly on selection clear buttons ([elastic#8105](elastic/eui#8105)) - Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of smaller widths instead of truncating ([elastic#8109](elastic/eui#8109)) - Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness where single items could overflow past the intended max width ([elastic#8110](elastic/eui#8110))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy should not send along the host header from the client and
instead should pass a host header derived from the configured
elasticsearch url, otherwise Kibana cannot run on a different host than
elasticsearch.
Fixes #8093