Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Visualize] Don't persist derived axis label #83512

Closed
kertal opened this issue Nov 17, 2020 · 3 comments
Closed

[Lens][Visualize] Don't persist derived axis label #83512

kertal opened this issue Nov 17, 2020 · 3 comments
Labels
enhancement New value added to drive a business result Feature:Lens Feature:Vis Editor Visualization editor issues impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented Nov 17, 2020 •
edited
Loading

PR #70039 allows the user to provide custom field names. When testing this, @flash1293 reported, that when changing a custom field name, the change is ignored in the axis name.

You can reproduce it (when #70039 was merged):

  • Set custom name for numeric field
  • Go to Visualize and create an area chart using this field
  • Y axis is called "Average "
  • Go to management and rename field
  • Go back to Visualize
  • Field name changed in the metrics configurator, but the axis is still stuck on the old custom name

This is because this axis label is persisted in the saved object:

Bildschirmfoto 2020-11-16 um 18 38 24

Since this is a default and any changes in language, wording, field name are ignored, it would be good practice not to persist this label in visState.
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal added enhancement New value added to drive a business result Feature:Vis Editor Visualization editor issues labels Nov 17, 2020
@kertal kertal changed the title [Visualize] Don't persist derived axis name [Visualize] Don't persist derived axis label Nov 17, 2020
@flash1293
Copy link
Contributor

Adding Lens label as well because this happens in Lens as well.

@flash1293 flash1293 changed the title [Visualize] Don't persist derived axis label [Lens][Visualize] Don't persist derived axis label Nov 18, 2020
@flash1293 flash1293 mentioned this issue Nov 26, 2020
Open
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 1, 2023
@stratoula
Copy link
Contributor

Closing in favor of #84419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Lens Feature:Vis Editor Visualization editor issues impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kertal @flash1293 @elasticmachine @stratoula