Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query][Security Solution][Timeline]Timeline mentioned instead of Template in various areas of Security Solution / Timeline Tab #87469

Closed
ghost opened this issue Jan 6, 2021 · 11 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timeline Security Solution Timeline feature fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0

Comments

@ghost
Copy link

ghost commented Jan 6, 2021

Describe the bug
[Security Solution][Timeline]Timeline mentioned instead of Template in various areas of Security Solution / Timeline Tab

Build Details:

Platform: Staging
Version: 7.11.0
Commit: f3abc08ac648f8b302733c5c22a39048314a027c
Build number: 37399
Artifact: https://staging.elastic.co/7.11.0-710164a0/summary-7.11.0.html

Browser Details
All

Preconditions

  1. Elastic Cloud environment should be available having "7.11.0" BC1 ES version running.
  2. Install Agent+Endpoint on the above environment

Steps to Reproduce

  1. Navigate to Security / Timeline Tab .
  2. Perform below operation under Template sub tab.
    import timeline button
    import timeline pop-up details
    delete template warning message
    imported template filename

Actual Result
Generic Functionality is used in buttons, pop-up, message, details, exported Filename

Expected Result
Distincition in code should be there for Timeline and Template operation for rich user experience .

As messages/text contradicts the operation performed

Screenshots

  • Import Timeline button label
    image
  • Import Timeline button on click pop-up
    image
  • Delete Template pop-up
    image
  • Exported Template filename
    image
  • Only Favorite filter text
    image

Query

We have observed the some of the operation ( screenshot shared above) have not distinction in the button labeling , texts , etc...
Whereas there are ares too which have distinction between the timeline & Templatelike below
image
image

So could you provide the input if it is expected or we should move to file a bug for above mentioned areas of application.

@ghost
Copy link
Author

ghost commented Jan 6, 2021

@manishgupta-qasource Please review

@manishgupta-qasource
Copy link

Reviewed & Assigned to @MadameSheema

@manishgupta-qasource manishgupta-qasource added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Timeline Security Solution Timeline feature labels Jan 6, 2021
@manishgupta-qasource manishgupta-qasource changed the title [Security Solution][Timeline]Timeline mentioned instead of Template in various areas of Security Solution / Timeline Tab [Query][Security Solution][Timeline]Timeline mentioned instead of Template in various areas of Security Solution / Timeline Tab Jan 6, 2021
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jan 6, 2021
@MadameSheema
Copy link
Member

@XavierM can you please take a look at this and help to prioritise? thanks :)

@XavierM
Copy link
Contributor

XavierM commented Jan 27, 2021

@monina-n can you advise us on what will be the best UX on this one?

@monina-n
Copy link

@XavierM let me know if there's any other questions

Updated UX:

  • Import Timeline button label
    image

Change: The button will now only say "Import" instead of "Import timeline"

  • Import Timeline button on click pop-up
    image

Change: Info text will say "Select a security timeline or timeline template to import" (copy help needed)

  • Delete Template pop-up
    image

Change: Info text will say "You will not be able to recover this timeline template or its notes once deleted."

  • Only Favorite filter text
    image

Change: Empty table text will now say "0 timeline templates match the search criteria"

@angorayc
Copy link
Contributor

angorayc commented Feb 9, 2021

  • Import Timeline button on click pop-up
    image

Change: Info text will say "Select a security timeline or timeline template to import" (copy help needed)

As we can import multiple timelines / templates in a file at a time, so I change the wording to Select a security timeline or timeline template file to import instead

@MadameSheema
Copy link
Member

@karanbirsingh-qasource can you please validate the fix of this issue on the last BC? Thanks :)

@ghost
Copy link
Author

ghost commented Mar 22, 2021

Hi @MadameSheema & @angorayc

Thanks for the Update .

we have validated this ticket on 7.12.0 BC5 and found it fixed , apart from 02 Question regarding the Ticket Fix.

Build Details:

Version: 7.12.0 BC5
Commit:b7f9a41f486a2910ef22a1274ec734219c35ca3e
Version : 39309

So can you please look into the below question , else we are good to close this issue.

Questions

Q1. Is this area "same filename i.e timelines_export for exported timeline and Template mentioned in Issue , going to fixed or not as it is still occuring?
image

Q2. In ticket Conversation Update text for Import Dialog box is "Select a security timeline or timeline template file to import ". However in actual Security is missing ahead the timeline in the Description.

Change: Info text will say "Select a security timeline or timeline template to import" (copy help needed)

image

Observations:

Please find below areas which is now reflecting correctly as per the ticket request .

  • Import Button on Timeline & Timeline Template Sub Tabs
    image
  • Import Timeline button on click pop-up
    image
  • Select a timeline or timeline template file to import description for Import dialog box
    image
  • Delete Timeline Template Description
    image
    image
  • Filter Text for Timeline and Template
    image
    image
  • Success prompt for Timeline and Timeline-Template export
    image
    image

@angorayc
Copy link
Contributor

Hello @karanbirsingh-qasource ,

For question 1, it's fine to leave the file name and the timelineType as it is in exported timeline. As users can rename the file name if they want, and we still need the timelineType when import a timeline.

question 2, We decide to remove the word security as considering of the future use case, so it is expected.

@ghost
Copy link
Author

ghost commented Mar 22, 2021

Thanks @angorayc for the instant feedback on our Question.

As all queries and resolved and some are expected . Hence closing this ticket and adding "QA Validated" label to it.

c.c @MadameSheema

@ghost ghost closed this as completed Mar 22, 2021
@ghost ghost added the QA:Validated Issue has been validated by QA label Mar 22, 2021
@ghost
Copy link

ghost commented Mar 30, 2021

Bug Conversion:

Updated 01 Test-Case for this Ticket
https://elastic.testrail.io/index.php?/cases/view/22488

Thanks!!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timeline Security Solution Timeline feature fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0
Projects
None yet
Development

No branches or pull requests

5 participants